Fix/block sequence fallback#757
Conversation
Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
03cb01c to
71b74ef
Compare
Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
Add MockClearServiceIDsCache() before and after the plural arrivals endpoint call in TestArrivalsAndDeparturesForStopHandler_MultiAgency_Regression, following the same pattern established in setupDelayPropTestData and TestArrivalsAndDeparturesForStop_VehicleWithNilID. This prevents a stale cache entry for "20100101" from hiding the newly inserted "service1" calendar when tests share the same GtfsManager instance. Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
|
Hi @aaronbrethorst , |
|
Hi @aaronbrethorst, just checking in on this PR. Happy to make any changes if needed. Thanks! |
|
Hi @aaronbrethorst, |
|
@ashnaaseth2325-oss please fix merge conflicts! |
1 similar comment
|
@ashnaaseth2325-oss please fix merge conflicts! |
|
Thanks for pointing this out @aaronbrethorst ! |
|
Hi @aaronbrethorst |
|
I am terribly sorry I completely missed that you had pushed up changes to this branch after my code review! Can I ask you to rebase this branch to fix all of the merge conflicts? Please reopen the PR after that. Again, my sincerest apologies. |
1. SUMMARY
Fixes a bug where the function returned
0on DB error instead of the givenstopSequence.Keeps fallback behavior consistent.
2. FIX
3. VERIFICATION
Result: returns
stopSequence(not0)