Repository navigation
CI: make hugo.yml lint-compliant, drop stale exemptions - #690
Merged
Merged
Conversation
The pre-commit, yamllint, and zizmor exemptions for hugo.yml referenced the OSGeo#599 migration stack, which merged. Fix the remaining lint issues in hugo.yml (document start, line length, unquoted runner.temp) and remove the exemptions along with the yamllint ignores for the compose files.
Removing the actionlint exemption surfaced this pre-existing finding. Rewrite the A && B || C install line as an if-block so npm ci failure is not conditioned on the lockfile test.
cwhite911
force-pushed
the
ci-stale-exemptions
branch
from
August 28, 2026 03:48
97f121d to
63c8d8e
Compare
cwhite911
marked this pull request as ready for review
August 28, 2026 03:51
echoix
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pre-commit (actionlint), yamllint, and zizmor exemptions for
.github/workflows/hugo.ymlsaid "remove once #599 merges". #599 merged, but hugo.yml still had the lint issues the exemptions were hiding: missing document start, two over-long wget lines, and unquotedrunner.temp(SC2086). This fixes hugo.yml, removes the exemptions, and drops the yamllint ignores for the compose files (which only needed document-start markers).Verified:
pre-commit run --all-filesclean; both compose files still parse.Part of the cleanup stack preparing #638.