Repository navigation
Conversation
The lightbox module was transpiled for old browsers, then loaded with type=module, which those browsers ignore. Serve the ES module minified and fingerprinted; drop the @babel devDependencies.
Drop exec allowances for tools the build never invokes (dart-sass-embedded, postcss, babel, npx) and allow sass ahead of the Dart Sass switch. Remove the misplaced enableInlineShortcodes key under [security] and two mounts whose sources do not exist (bootstrap-icons is not a dependency; there is no root assets directory).
- .Data.Pages to .Pages; unguarded .File.UniqueID comparisons to .RelPermalink; File.Dir where-clause tightened to direct children - .Site.Author and .Site.Config.Services.RSS (removed upstream) dropped from rss.xml along with its unused page-collection prologue - where .Site.Pages to site.RegularPages for news listings; the news section page no longer lists itself as a 2019 item - global toCSS/minify/fingerprint aliases to their resources.* forms - Site.BaseURL string concatenation emitted double-slash URLs; use relURL. zenodo-card partial now receives its context.
cwhite911
added
CI
Contributor
Author
|
Superseded by the stacked-PR version of this branch (same commits, same-repo branch so it can be stacked); link follows. |
Contributor
Author
|
Resubmitted as #694, bottom of stack #696. |
Member
Ok, it doesn't work for PRs from forks... :( Maybe that's why I wasn't able for the main repo to get it working in San-Michele. I didn't find why until now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes every template construct that errors on current Hugo, so #638 gets closer to a version-pin flip. Three commits:
type="module", which those browsers ignore. The module is now served minified and fingerprinted;@babel/*devDependencies dropped.security.exec.allowreduced to['^go$', '^sass$'](nothing invokes dart-sass-embedded, postcss, babel, or npx;^sass$pre-arms the Dart Sass switch). Removes the misplacedenableInlineShortcodesunder[security]and two mounts with nonexistent sources..Data.Pages, unguarded.File.UniqueID,.Site.Author,.Site.Config.Services.RSS, and the globalminify/fingerprintaliases replaced with forms valid on both 0.113 and current Hugo (toCSSstays:resources.ToCSSis removed upstream,css.Sassdoes not exist on 0.113).Site.BaseURLstring concatenation emitted//URLs on every page; nowrelURL. News listings usesite.RegularPages, which also stops the news section page listing itself as a 2019 item.Verified on Hugo 0.113 (production compose build; output diff limited to the intended URL fixes) and on Hugo 0.164 extended, which now builds with zero errors. Remaining 0.164 items are upgrade-time only:
_buildfront matter rename in six download pages,allowContentfor the four 1996 HTML news files,languageCode/languageName/.Site.Datarenames (their replacements do not exist on 0.113), and the sitemap output format.Part of the cleanup stack preparing #638.