Couple of fixes for multipatch adaptivity#891
Open
akva2 wants to merge 2 commits into
Open
Conversation
When extendRefinementDomain() adds new indices to the refinement set, the propagation loop must continue to propagate those additions across patches. Previously, changed was only updated when extracting from the initial seed set, not when the refinement domain was extended by neighbor conformity constraints.
getBoundaryCovered() previously relied on one-way containment checks, which can miss boundary nodes when refined (smaller) and coarse (larger) basis function supports overlap without strict containment. Changed to overlap-based detection: a boundary node is considered covered if it overlaps (via getOverlappingNodes()) with any refined node and lies on the boundary. This is more robust for selective refinement patterns on multi-patch domains where support hierarchies vary per edge.
akva2
force-pushed
the
fix_multipatch_refinement
branch
from
38a84b5 to
e6af6e2
Compare
Member
Author
|
jenkins build this with downstreams please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two copilot identified issues;