Repository navigation
Backport8 8684 8699 v1 - #16503
Closed
catenacyber wants to merge 2 commits into
Closed
Backport8 8684 8699 v1#16503catenacyber wants to merge 2 commits into
catenacyber wants to merge 2 commits into
Conversation
Ticket: 8684 The behavior of the rule alert ip any any -> any any (pcre:"/.*mc|\H+$/"; sid:4;) depended upon the presence of another rule such as alert ip any any -> any any (content:"*mcH"; sid:5;) With the sid 5 content rule, the code went through PrefilterPktStream which updated raw_stream_progress, which ended up updating raw_progress_rel which was used on later packets to know where to start. Without the sid 5 content rule, there was no update of these progresses. It led to quadratic complexity, as for each new packet, we ran the pcre engine on the whole tcp stream from the beginning, with the newly added payload data. Fix is to process sid 4 pcre rule the same way whether there is or there is not a sid 5 content rule. So, in case we do not have a mpm store for a signature group head, we register a dummy stream prefilter, whose goal will just be to update raw_stream_progress (cherry picked from commit f87b8e6)
Change the byte order of vlan TCI when extracting it from vlan_hdr in xdp_filter.c. This fixes xdp bypass for vlan tagged packets, as without the fix flows that are supposed to be bypassed by the xdp filter are not bypassed. Ticket: 8699 (cherry picked from commit 5cb7a0d)
suricata-review-bot
left a comment
suricata-review-bot
left a comment
There was a problem hiding this comment.
AI-generated review.
Verdict: approve
No high- or medium-severity findings.
Automated at commit 055855bd1580 using Claude Code with claude-opus-5-5/xhigh. Run: b8d69c0621edd953.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main-8.0.x #16503 +/- ##
==============================================
- Coverage 81.69% 81.68% -0.01%
==============================================
Files 1020 1020
Lines 281745 281760 +15
==============================================
- Hits 230161 230149 -12
- Misses 51584 51611 +27
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
victorjulien
approved these changes
Oct 23, 2026
|
WARNING:
Pipeline = 35208 |
Member
|
Merged in #16509, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/8685
https://redmine.openinfosecfoundation.org/issues/8700
Describe changes: