Repository navigation
Conversation
Such as /dev/zero Ticket: 9106 (cherry picked from commit 46aa14f)
suricata-review-bot
left a comment
suricata-review-bot
left a comment
There was a problem hiding this comment.
AI-generated review.
Verdict: approve
No high- or medium-severity findings.
Automated at commit 712830938018 using Claude Code with claude-opus-5-5/xhigh. Run: 0b26f5bf4c1be502.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main-8.0.x #16468 +/- ##
==============================================
- Coverage 81.68% 81.67% -0.01%
==============================================
Files 1020 1020
Lines 281718 281727 +9
==============================================
- Hits 230116 230100 -16
- Misses 51602 51627 +25
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
WARNING:
Pipeline = 34981 |
victorjulien
approved these changes
Oct 19, 2026
catenacyber
approved these changes
Oct 19, 2026
catenacyber
left a comment
catenacyber
left a comment
Contributor
There was a problem hiding this comment.
Good backport for me
I am not sure if Victor wants the openbsd pledge now or later...
Member
|
Merged in #16474, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SV_BRANCH=OISF/suricata-verify#3463
Automated backports to main-8.0.x for 8.0.8 from merged staging PRs
#14961 and #16459.
Dataset inputs must now be regular files. This also rejects previously
accepted /dev/null inputs.
Both commits built with the normal development sanitizer configuration. The
dataset SV regression passes after failing the bounded baseline check. The
OpenBSD-specific pledge race was not reproduced on this Linux test host.
Full Suricata-Verify: 2375 passed, 0 failed, 607 skipped.
[This backport PR was generated by a new automation in test.]