Skip to content

[19.0][MIG] survey_sale_generation: Migration to version 19.0 - #247

Merged
OCA-git-bot merged 23 commits into
OCA:19.0from
Tecnativa:19.0-mig-survey_sale_generation
Aug 25, 2026
Merged

OCA-git-bot merged 23 commits into
OCA:19.0from
Tecnativa:19.0-mig-survey_sale_generation

Conversation

@adasatorres-tecnativa

Copy link
Copy Markdown
Contributor

@OCA-git-bot OCA-git-bot added series:19.0 mod:survey_sale_generation Module survey_sale_generation labels Aug 12, 2026
@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot migration survey_sale_generation

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Aug 12, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 12, 2026
18 tasks done
chienandalu and others added 22 commits August 13, 2026 10:15
Currently translated at 3.0% (1 of 33 strings)

Translation: survey-15.0/survey-15.0-survey_sale_generation
Translate-URL: https://translation.odoo-community.org/projects/survey-15-0/survey-15-0-survey_sale_generation/it/
Currently translated at 100.0% (33 of 33 strings)

Translation: survey-15.0/survey-15.0-survey_sale_generation
Translate-URL: https://translation.odoo-community.org/projects/survey-15-0/survey-15-0-survey_sale_generation/es/
- We can configure a custom mail template for the quotation.
- Now it's possible to set a linked answer that acts as multiplier.

TT40983
Allow to set multiple products so one question can generate several
product lines
Allow to choose a quotation template
Allow to fill sale.order links from the survey answers

TT47576
Now we can use a single choice question to force the template into the
generated sale order.

TT51297
Currently translated at 100.0% (47 of 47 strings)

Translation: survey-17.0/survey-17.0-survey_sale_generation
Translate-URL: https://translation.odoo-community.org/projects/survey-17-0/survey-17-0-survey_sale_generation/it/
…ompany_id

When generating a quotation from a survey response, the sale order was being
assigned to the company of the `create_uid`. This is incorrect in multi-company
contexts, especially when the user has access to multiple companies and their
default company (`company_id`) is not the active one.

Instead, this commit uses `self.env.company` to retrieve the currently active
company from the context, which correctly reflects the company in which the
user is operating when completing the survey.

This change ensures that the sale order is created in the company active in the
user's session, avoiding multi-company integrity errors (e.g. trying to create
a record in a company other than the one currently active).

TT57057
@adasatorres-tecnativa
adasatorres-tecnativa force-pushed the 19.0-mig-survey_sale_generation branch from 2fedf3c to 6c06a4e Compare August 13, 2026 09:19
@adasatorres-tecnativa

Copy link
Copy Markdown
Contributor Author

ping @pilarvargas-tecnativa

@adasatorres-tecnativa
adasatorres-tecnativa force-pushed the 19.0-mig-survey_sale_generation branch from 6c06a4e to 81d8c3b Compare August 24, 2026 12:46
@adasatorres-tecnativa

Copy link
Copy Markdown
Contributor Author

There’s actually no issue with the tests. When I was transcribing the demo survey into the test setup, I forgot to add a field to the question about the Gold services. That field indicates whether you want to use a numeric field as a multiplier for the value of that question.

Sorry for any inconvenience caused.

@pilarvargas-tecnativa.

@pilarvargas-tecnativa

Copy link
Copy Markdown
Contributor

There’s actually no issue with the tests. When I was transcribing the demo survey into the test setup, I forgot to add a field to the question about the Gold services. That field indicates whether you want to use a numeric field as a multiplier for the value of that question.

Thanks for checking and clarifying! The confusion came from the 17.0 test documentation showing 1 while the actual expected behavior was 3. Thanks also for correcting it in 19.0 🙂

@adasatorres-tecnativa
adasatorres-tecnativa force-pushed the 19.0-mig-survey_sale_generation branch from 81d8c3b to 3fabb54 Compare August 25, 2026 07:28
@adasatorres-tecnativa
adasatorres-tecnativa force-pushed the 19.0-mig-survey_sale_generation branch from 3fabb54 to e7deccc Compare August 25, 2026 07:28
@adasatorres-tecnativa

Copy link
Copy Markdown
Contributor Author

@pilarvargas-tecnativa, It should already cover the check you mentioned.

@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-247-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit a1fcc23 into OCA:19.0 Aug 25, 2026
5 of 7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at e34e9aa. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
pedrobaeza deleted the 19.0-mig-survey_sale_generation branch August 25, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants