[19.0][MIG] stock_barcodes: Migration to 19.0 by hoattk-komit · Pull Request #742 · OCA/stock-logistics-barcode

hoattk-komit · 2026-02-05T03:56:57Z

Depend on:

[19.0][MIG] web_widget_numeric_step: Migration to 19.0#3429

sergio-teruel · 2026-02-26T21:51:28Z

Hi @hoattk-komit We are working in improvements in v18... Please follow it to add changes into your migration...

Thanks

hoattk-komit · 2026-02-27T02:45:45Z

Hi @hoattk-komit We are working in improvements in v18... Please follow it to add changes into your migration...

Thanks

Thanks for your comment, I'll do it

github-actions · 2026-06-28T13:15:45Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

Quan-nhm · 2026-07-17T09:42:07Z

+            # Remove all existing move lines and create a new one with 0 quantity
+            # to avoid issues with reservation
+            stock_move.move_line_ids.unlink()
+            self.env["stock.move.line"].create(


Should we set variable for self.env["stock.move.line"] into outside of the loop ?
example:

sml_env = self.env["stock.move.line"] for sml in self: .....

This code no longer exists after rebasing on the latest 18.0

Quan-nhm · 2026-07-17T09:55:37Z

            {
                "name": "Product test wo lot tracking",
-                "type": "product",
+                "type": "consu",


Should we also include is_storable? In version 16.0, the product type represents a storable product.

Quan-nhm · 2026-07-17T09:55:58Z


    # Overwrite is needed to take into account new domain values
-    product_id = fields.Many2one(domain=[("type", "in", _allowed_product_types)])
+    product_id = fields.Many2one(domain=Domain("type", "in", _allowed_product_types))


Should we also include is_storable in the domain? In version 16.0, the product type represents a storable product.

Quan-nhm · 2026-07-17T09:57:44Z

+                domain.append(Domain("inventory_quantity_set", "=", False))
                order = None
-            quants = self.env["stock.quant"].search(domain, order=order)
+            quants = self.env["stock.quant"].search(Domain.AND(domain), order=order)


Should change to search_fetch?

Kept search() as in 18.0: the quants are used as full records right after (kanban and writes), so search_fetch brings no real gain here

sergio-teruel · 2026-07-17T10:01:53Z

Please, @hoattk-komit , Can you review the PR in v18??

#725

Is ready to merge, after that you can base you migration from 18.0

Thanks.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-barcode-15.0/stock-logistics-barcode-15.0-stock_barcodes Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-15-0/stock-logistics-barcode-15-0-stock_barcodes/

Currently translated at 98.0% (248 of 253 strings) Translation: stock-logistics-barcode-15.0/stock-logistics-barcode-15.0-stock_barcodes Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-15-0/stock-logistics-barcode-15-0-stock_barcodes/it/

…led for products without tracking

…in is stock_moves without reservations

…stock move lines TT41789

…ations

…ions

Depend on stock_move_line_qty_picked and remove the duplicate field definitions, computes and SQL initialization. Reuse its view fields without displaying duplicate columns. Show picked quantities by default and explain how normal validation and partial picking behave, including Spanish translations. Cover normal validation without entering picked quantities, manual partial quantities, scanner-to-manual and manual-to-scanner preparation, partial validation from the standard picking form and clearing scans by unpicking. The suite passes all 176 tests with the shared dependency installed. Deploy with the stock_move_line_qty_picked installation and upgrade fix so existing prepared quantities and partial scans are preserved when the shared field is adopted.

…cords The grouping key of the todo records is evaluated both on the moves or move lines being grouped and on the todo records themselves, to find the current todo line again after a scan. Todo records only copy some fields of their source records, so a key like object.picking_id,object.product_id raised an AttributeError when opening the reader. Evaluate the key on the first source record of the todo line, which by definition gives the key of its group.

Port the multi-move scenarios of 18.0-FIX-stock_barcodes-sibling_moves_repartition (fffef9e). Its production changes are already part of this branch: 76dc071 excludes cancelled and done moves from the moves to do, caps a read on a line while sibling moves still have pending demand, and allocates reservations first and then the remaining unreserved demand, all in the scanned unit of measure. Only the tests were missing: serial reads going to an unreserved or reserved sibling, a real excess that still warns and can be forced, a cancelled sibling that neither absorbs reads nor counts as demand, and repeated or manual untracked reads split by demand. The tests live in their own class based on the common fixtures instead of inheriting TestStockBarcodesPicking, which would run that whole suite a second time. The comment on the remaining quantity now states that it is a real excess over the total demand.

Quantities read are now handled by two independent options: - Replace quantity on each reading (no_increase_qty_done) chooses whether a confirmed reading is added to the quantity already recorded or replaces it, for both the done quantity of picking move lines and the counted quantity of inventory quants. It previously only applied to pickings, while inventories used accumulate_read_quantity with the opposite meaning. - Accumulate repeated readings (accumulate_read_quantity): with manual confirmation, reading the same product, lot or packaging again before confirming adds one unit (or packaging) to the quantity to confirm. It is applied once per scan in process_barcode, only when the barcode was matched by the product, packaging or lot option, so location scans, the lot read that completes a product reading and quantities filled from stock do not add units. Combined, units can be counted one by one on the screen and the result replaces the counted quantity. Confirming a counted inventory line edited from the list added its whole quantity again when readings were added; the edited quant is now always replaced. The 18.0.1.5.0 migration keeps the inventory behavior of each database (the inventory screen always uses the Inventory group), leaves the screen accumulation disabled and maps the 15.0 move_lines value of source_pending_moves to move_ids. The unused show_all_quantities and allow_direct_partial_delivery options are removed: nothing reads them since the candidate picking wizard was removed. The help of every option describes what the code does, and strings that called a packaging "package" (packaging quantity, "More than one packaging found", the "Put in back" typo of the put in pack button) are fixed. The readme documents every option grouped by purpose, starting from the analysis of each operation flow with the customer, and the roadmap lists common flows not covered yet.

In 15.0 the picking internal note was shown in the candidate pickings kanban, so operators could see special instructions (e.g. coming from sale_stock_picking_note). That kanban was removed during the migration and the note was no longer displayed. Add a computed picking_note field on the picking wizard that ignores empty HTML values, and show it at the top of the scan content in red, italic and bold. It can be hidden with the hide_note context key, as in 15.0.

Once a product is read, a button next to it on the scan screen opens a touch friendly dialog with the on hand, incoming, outgoing and forecasted quantities of the product and its stock in each internal location of the operation scope. Locations are listed in removal strategy order, reversed on receptions, and tapping one fills the destination location on receptions and the source location otherwise. Buttons next to the source and destination location fields open the same dialog without the product quantities to just pick a location. Their context (location_stock_field, location_stock_reverse) forces the filled field and the order, so internal transfers list the source locations in removal order and the destination ones reversed. On small screens, where labels become icons, the icons replace these buttons. _get_location_stock_field, _is_location_stock_reversed, _get_location_stock_parent_locations and _sort_location_stock let other modules change the filled field, the order and the scope.

…nation In receptions, choosing another destination bin redirected the existing move line of the product to it, including the units already read in the previous bin. Receiving three units of a product without tracking in one bin and the last one in another left the three units in the last bin.

…sers(2,) | res.users.tester(1,)

hoattk-komit · 2026-10-23T09:28:16Z

@hoattk-komit we also had ours here Therp#1 maybe you can cherry-pic our commits after you review and test. Alternatively we can submit ours to OCA since v18.0 has been merged #725.

Thanks @KKamaa , I reviewed your branch: your 19.0 fixes (Odoo 19 API alignment, packaging UoM dispatch, scanner tests) are included in the [MIG] commit with you as co-author. Instead of the upstream sync commit I forward-ported the 18.0 commits individually to keep their authorship.

hoattk-komit · 2026-10-23T09:28:42Z

Hi,

Small issue in stock_barcodes/models/stock_quant.py: the override of action_apply_inventory drops the date argument of the Odoo 19 signature (def action_apply_inventory(self, date=None) in stock/models/stock_quant.py):
def action_apply_inventory(self):
    res = super().action_apply_inventory()
Any other module that overrides the method with the standard signature and calls super().action_apply_inventory(date=date) then fails with:
TypeError: StockQuant.action_apply_inventory() got an unexpected keyword argument 'date'
Suggested fix:
def action_apply_inventory(self, date=None):
    res = super().action_apply_inventory(date=date)

Thanks, fixed: the override now uses the Odoo 19 signature and passes date through.

KKamaa · 2026-10-23T20:53:30Z

+const _origOnBarcodeScanned = BarcodeHandlerField.prototype.onBarcodeScanned;
+
+patch(BarcodeHandlerField.prototype, {
+    onBarcodeScanned(event) {


@hoattk-komit Odoo 19's barcode handler updates the record asynchronously. Here the original handler is called without awaiting record.update(), and dummy_on_barcode_scanned is clicked immediately afterward.
The button can therefore process an empty or previously scanned barcode before _barcode_scanned finishes its onchange.
Could we await the update before clicking, restrict this behavior to the OCA wizard's _barcode_scanned field, and add a Hoot regression test?
We fixed this in Therp commit 361bfdc0, including tests for asynchronous ordering and preserving standard Odoo barcode behavior.

KKamaa · 2026-10-23T20:55:05Z

+import {kanbanView} from "@web/views/kanban/kanban_view";
+import {registry} from "@web/core/registry";
+
+registry.category("views").add("stock_barcodes_kanban", {


@hoattk-komit It looks like removing the custom kanban renderer also removed the subscriber for stock_barcodes_kanban_update.
stock_quant.enable_current_operations() still sends the enable_operations notification, while stock_barcodes_read_inventory_views.xml still renders the +/- buttons inside an element with d-none (line 160).
I couldn't find a replacement subscriber that removes this class, so those quantity-adjustment controls appear to remain hidden.
Could we restore this behavior in the kanban renderer or another suitable component and add a Hoot test?
The implementation in Therp's kanban_renderer.esm.js shows the previous subscription and visibility update.

KKamaa · 2026-10-23T20:57:28Z

+            vals["location_dest_id"] = self.location_dest_id.id
+        return vals
+
+    def action_barcode_scan(self, option_group=False, wiz=False):


@hoattk-komit Could we add self.ensure_one() at the beginning of action_barcode_scan()?
The method creates one wizard using self.id and the picking's individual fields, so its contract is clearly single-record. Making that explicit avoids confusing failures when invoked on multiple pickings.
Our Therp branch already includes this guard.

KKamaa · 2026-10-23T20:58:28Z

@@ -0,0 +1,2 @@
+odoo-addon-web_widget_numeric_step @ git+https://github.com/OCA/web.git@refs/pull/3429/head#subdirectory=web_widget_numeric_step


@hoattk-komit OCA/web#3429 (web_widget_numeric_step) was already merged into 19.0, so we can remove its temporary PR dependency here and use the standard addon dependency.
stock_move_line_qty_picked is still pending in OCA/stock-logistics-workflow#2459, which explains the remaining unreleased-dependency CI failure.
Could we clean up the merged dependency now and remove the remaining temporary PR reference once #2459 is merged?

KKamaa · 2026-10-23T21:01:02Z

@hoattk-komit check codecov errors found so that the pipeline can be green

oca-cla-bot · 2026-10-30T09:24:20Z

The following commit authors need to sign the Contributor License Agreement:

Quan-nhm

Hi, it would be nice if you could review it again.
For the issue the lot I have tested and I cannot select any lot eventhough the product already have few low

Quan-nhm · 2026-10-30T09:40:03Z

                                        name="lot_id"
                                        options="{'no_create': True, 'no_open': True}"
-                                        domain="[('product_id', '=', product_id)]"
+                                        domain="[('id', 'in', product_packaging_uom_ids)]"


Why do we have Lot ID in product_packaging_uom_ids ??

Quan-nhm · 2026-10-30T09:44:16Z

-                    "qty_picked": qty_done,
+                    "qty_picked": self.product_id.uom_id._compute_quantity(
+                        qty_done, line.product_uom_id, round=False
+                    ),


I think the qty_done already _compute_quantity in line 692

line_qty = scan_uom._compute_quantity( assigned_qty, line.product_uom_id, round=False )

Quan-nhm · 2026-10-30T09:48:26Z

            )
-        # Assign lot created or found to wizard scanning barcode lot_id field
+            product = self.product_id.sudo() if is_stock_manager else self.product_id
+            uom = Uom.create(self._prepare_uom_values())


Should we check if the UoM is existed or not before create a new UoM ?

- Packagings are units of measure: packaging_uom_id on the scan wizards, packaging barcodes read from product.uom, new packaging wizard creating a uom.uom relative to the product unit and its product.uom barcode - stock.quant.package -> stock.package, digits "Product Unit", no stock.move name, no posx/posy/posz (locations sorted by complete name) - qty_picked comes from stock_move_line_qty_picked, as in 18.0 - action_apply_inventory(date=None) signature - JS adapted to the Odoo 19 web client: dropped the view_button and view_compiler patches (core renders data-hotkey), Owl/bus API updates, Hoot tests - Tests adapted to Odoo 19 Co-authored-by: Agentiko <amuntri@gmail.com> Co-authored-by: KKamaa <kevkamaa96@gmail.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

hoattk-komit mentioned this pull request Feb 5, 2026

Migration to version 19.0 #722

Open

2 of 3 tasks

hoattk-komit force-pushed the 19.0-mig-stock_barcodes branch 4 times, most recently from 767e75a to 541138f Compare February 10, 2026 11:11

github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 28, 2026

hoattk-komit force-pushed the 19.0-mig-stock_barcodes branch from 541138f to 81843ac Compare July 3, 2026 10:00

OCA-git-bot added mod:stock_barcodes Module stock_barcodes series:19.0 labels Jul 3, 2026

github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 5, 2026

Quan-nhm reviewed Jul 17, 2026

View reviewed changes

weblate and others added 15 commits July 26, 2026 16:36

[IMP] stock_barcodes: add Barcode Option Group for not planned pickings

51863f7

[UPD] Update stock_barcodes.pot

6c89a96

stock_barcodes 15.0.1.1.0

9eb2182

[FIX] stock_barcodes: add migration script

9dc24bc

[FIX] stock_barcodes: Do not create a lot with create lot option enab…

9905235

…led for products without tracking

[FIX] stock_barcodes: Pending moves are not displayed when moves orig…

d9a8eb9

…in is stock_moves without reservations

stock_barcodes 15.0.1.2.0

c7ab7de

[FIX] stock_barcodes: put in pack call method fails

cd72bb6

stock_barcodes 15.0.1.2.1

8719b30

[FIX] stock_barcodes: Not pending moves when origin pending moves is …

20085ff

…stock move lines TT41789

stock_barcodes 15.0.1.2.2

1014df8

carlosdauden and others added 19 commits October 23, 2026 16:10

[FIX] stock_barcodes: create packaging without optional sale fields

591cf31

[FIX] stock_barcodes: preserve inventory ownership when counting

c970639

[FIX] stock_barcodes: use Odoo 18 barcode and view APIs

f49ae40

[FIX] stock_barcodes: allocate scans with consistent units and reserv…

ec856ce

…ations

[FIX] stock_barcodes: honor owners and the full scanner transfer scope

d422a8b

[I18N] stock_barcodes: refresh catalogs and complete Spanish translat…

e3597d2

…ions

[I18N] stock_barcodes: Update translation files

5d61333

[I18N] stock_barcodes: Update translation files

8d3a53d

[UPD] Update stock_barcodes.pot

068d238

[BOT] post-merge updates

8f9bc88

[IMP] stock_barcodes: pre-commit auto fixes

65c032c

[FIX] test_barcodes_generator_abstract: inconsistent models in: res.u…

1c77b5e

…sers(2,) | res.users.tester(1,)

hoattk-komit force-pushed the 19.0-mig-stock_barcodes branch from 07c47da to 8771c71 Compare October 23, 2026 09:20

KKamaa suggested changes Oct 23, 2026

View reviewed changes

hoattk-komit force-pushed the 19.0-mig-stock_barcodes branch from 8771c71 to 7657162 Compare October 30, 2026 09:24

Quan-nhm reviewed Oct 30, 2026

View reviewed changes

hoattk-komit and others added 2 commits October 30, 2026 17:20

[DON'T MERGE] test-requirements.txt

3d35632

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

hoattk-komit force-pushed the 19.0-mig-stock_barcodes branch from 7657162 to 3d35632 Compare October 30, 2026 10:31

		@@ -0,0 +1,2 @@
		odoo-addon-web_widget_numeric_step @ git+https://github.com/OCA/web.git@refs/pull/3429/head#subdirectory=web_widget_numeric_step

Conversation

hoattk-komit commented Feb 5, 2026

Uh oh!

sergio-teruel commented Feb 26, 2026

Uh oh!

hoattk-komit commented Feb 27, 2026

Uh oh!

github-actions Bot commented Jun 28, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sergio-teruel commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hoattk-komit commented Oct 23, 2026

Uh oh!

hoattk-komit commented Oct 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KKamaa commented Oct 23, 2026

Uh oh!

oca-cla-bot Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Quan-nhm left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

sergio-teruel commented Jul 17, 2026 •

edited

Loading

oca-cla-bot Bot commented Oct 30, 2026 •

edited

Loading