Skip to content

[18.0][IMP] base_import_match: add Match column to import preview - #426

Open
yostashiro wants to merge 1 commit into
OCA:18.0from
qrtl:6195-imp-base_import_match
Open

[18.0][IMP] base_import_match: add Match column to import preview#426
yostashiro wants to merge 1 commit into
OCA:18.0from
qrtl:6195-imp-base_import_match

Conversation

@yostashiro

@yostashiro yostashiro commented Feb 27, 2026

Copy link
Copy Markdown
Member

Allow users to select match fields directly in the import preview UI.
Checked fields are used to find existing records but are not written.
Pre-configured import match rules pre-check the defaults.

UI selections prevail over configured rules; empty selection skips
matching entirely. When a match finds zero or multiple records, the
entire import is blocked with per-row error messages.

This will allow ad-hoc selection of matching keys at data import.
image

@qrtl QT6195

@yostashiro
yostashiro force-pushed the 6195-imp-base_import_match branch 2 times, most recently from 9dfa914 to 453db6f Compare February 28, 2026 09:46
@yostashiro
yostashiro marked this pull request as ready for review February 28, 2026 09:53
@yostashiro
yostashiro force-pushed the 6195-imp-base_import_match branch from 453db6f to 5700379 Compare February 28, 2026 10:34
@yostashiro yostashiro changed the title [18.0][IMP] base_import_match: add Match Only column to import preview [18.0][IMP] base_import_match: add Match column to import preview Feb 28, 2026
@yostashiro
yostashiro force-pushed the 6195-imp-base_import_match branch 3 times, most recently from aaff606 to 63ed5ec Compare March 3, 2026 09:29
Sanami0329

This comment was marked as resolved.

@Sanami0329 Sanami0329 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AungKoKoLin1997 AungKoKoLin1997 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: LGTM

@baf-adhoc baf-adhoc left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok!

AungKoKoLin1997 added a commit to qrtl/server-backend that referenced this pull request Jun 26, 2026
Add a Match column to the import preview UI. Checking a field uses it to
find existing records (match key) without writing its value during import.
Pre-configured Import Match rules pre-check their fields automatically. If a
row matches zero or multiple records, the whole import is blocked.

Enhancement from OCA#426.
AungKoKoLin1997 added a commit to qrtl/server-backend that referenced this pull request Jun 29, 2026
Add a Match column to the import preview UI. Checking a field uses it to
find existing records (match key) without writing its value during import.
Pre-configured Import Match rules pre-check their fields automatically. If a
row matches zero or multiple records, the whole import is blocked.

Enhancement from OCA#426.
AungKoKoLin1997 added a commit to qrtl/server-backend that referenced this pull request Jun 30, 2026
Add a Match column to the import preview UI. Checking a field uses it to
find existing records (match key) without writing its value during import.
Pre-configured Import Match rules pre-check their fields automatically. If a
row matches zero or multiple records, the whole import is blocked.

Enhancement from OCA#426.
@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 12, 2026
Allow users to select match fields directly in the import preview UI.
Checked fields are used to find existing records but are not written.
Pre-configured import match rules pre-check the defaults.

UI selections prevail over configured rules; empty selection skips
matching entirely. When a match finds zero or multiple records, the
entire import is blocked with per-row error messages.
@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 6195-imp-base_import_match branch from 63ed5ec to 29c8c71 Compare July 27, 2026 07:33
@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants