Repository navigation
fix bad logging within map_values - #464
Merged
Merged
Conversation
pedrobaeza
approved these changes
Aug 26, 2026
Member
|
Please rephrase the commit message to |
Hugo-Trentesaux
force-pushed
the
patch-1
branch
from
August 27, 2026 08:05
b37cd03 to
e3af0ff
Compare
Contributor
Author
|
hbrunn
approved these changes
Sep 16, 2026
Member
|
/ocabot merge nobump |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
unittests fails |
Member
that's github's shaky infrastructure, fixed in #467. merging manually as ocabot didn't seem to do its job here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When model is an empty recordset (
env["res.partner"]), the condition is falsy, where we want it to be truthy instead (model._table is actually defined).