Skip to content

[18.0][ADD] resource_booking_google_meet: default bookings to Google Meet videocall - #224

Open
dnplkndll wants to merge 2 commits into
OCA:18.0from
ledoent:18.0-add-resource_booking_google_meet
Open

dnplkndll wants to merge 2 commits into
OCA:18.0from
ledoent:18.0-add-resource_booking_google_meet

Conversation

@dnplkndll

Copy link
Copy Markdown
Contributor

Summary

Adds resource_booking_google_meet — a small glue module that ensures the
google_calendar integration auto-generates a unique Google Meet URL for each
resource.booking confirmation.

Problem: google_calendar._google_values() only adds conferenceData (which
triggers Meet URL generation) when both videocall_location and location are
falsy on the event:

if not self.google_id and not self.videocall_location and not self.location:
    values['conferenceData'] = {'createRequest': {'requestId': uuid4().hex}}

If the booking type has a physical address (location), the condition fails even when
videocall_location is empty, so no Meet URL is ever generated.

Fix: Override _prepare_meeting_vals() to clear location from the meeting vals
when the booking type has no custom videocall_location. This ensures the
google_calendar sync always requests conferencing for remote-only bookings.

When the booking type does have a videocall_location (e.g. a static Zoom personal
room), the module leaves everything unchanged.

Checklist

  • Module follows OCA conventions (pyproject.toml, readme/, pre-commit clean)
  • author includes Odoo Community Association (OCA)
  • license: AGPL-3
  • maintainers: ["dnplkndll"]
  • Tests (next PR — needs a google_calendar mock)

@OCA-git-bot OCA-git-bot added series:18.0 mod:website_appointment_booking Module website_appointment_booking mod:resource_booking_google_meet Module resource_booking_google_meet mod:resource_booking_sms Module resource_booking_sms labels May 19, 2026
@dnplkndll
dnplkndll force-pushed the 18.0-add-resource_booking_google_meet branch from 0b79020 to f2f8d87 Compare May 19, 2026 14:56
@OCA-git-bot OCA-git-bot removed mod:website_appointment_booking Module website_appointment_booking mod:resource_booking_sms Module resource_booking_sms labels May 19, 2026
@dnplkndll dnplkndll changed the title feat(resource_booking_google_meet): default new bookings to Google Meet videocall [18.0][ADD] resource_booking_google_meet: default bookings to Google Meet videocall May 19, 2026
@dnplkndll
dnplkndll force-pushed the 18.0-add-resource_booking_google_meet branch from 78841c6 to 0cf9cc0 Compare May 19, 2026 19:31
@dnplkndll
dnplkndll force-pushed the 18.0-add-resource_booking_google_meet branch from ace9441 to 1b6e4d3 Compare June 12, 2026 23:20
@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:resource_booking_google_meet Module resource_booking_google_meet series:18.0 stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants