Resolve a few pain points found from running Herostratus at work - #183
Merged
Merged
Conversation
One of the things I've been seeing in my Herostratus instance I run at $WORK is that the repositories in config.toml are constantly re-arranging, which results in unnecessary changes polluting the diff in the coordination repository.
This gives deterministic ordering at results in less run-to-run differences in the updated cache data.
This removes a source of a diff that's always present between any two runs, regardless of whether there were real changes.
Normally I'd shy away from updating everything in the Cargo manifest, because I find it painful when consuming libraries that do the same (I have to maintain projects at $WORK that have to maintain older stable Rust toolchains, or have pinned dependencies that are incompatible). But Herostratus is 1. an application 2. a hobby project 3. has a documented MSRV policy so ... get rekt anyone who doesn't like it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #145.
Closes #182.