Draft
Fix Android audiobook ended-state parsing for partial locators#202
Conversation
Co-authored-by: m-abs <1348705+m-abs@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job for integration tests on Android
Fix Android audiobook ended-state parsing for partial locators
Aug 12, 2026
ddfreiling
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Android integration job was failing in the audiobook end-of-playback path. The terminal
TimebasedState.endedevent could carry acurrentLocatorwithoutprogression/totalProgression, and Dart-side normalization crashed while rebuildingLocations.Root cause
ReadiumTimebasedState.fromJson()normalizes ended-state locators to1.0progress.Locator.copyWithLocations()/Locations.copyWith()with partially populated location data and hit a null-unsafe branch.Change
Locator/Locationscopy helpers to preserve existing values via explicit sentinel checks instead of the failing nullable helper path.1.0when the player reportsended.Regression coverage
positionand time fragment, with noprogressionfields.Changelog
flutter_readium_platform_interface/CHANGELOG.md.