Skip to content

fix(blink-cmp): Extended auto_show type - #937

Open
itpropro wants to merge 2 commits into
NotAShelf:mainfrom
itpropro:fix/blink_auto_show
Open

fix(blink-cmp): Extended auto_show type#937
itpropro wants to merge 2 commits into
NotAShelf:mainfrom
itpropro:fix/blink_auto_show

Conversation

@itpropro

@itpropro itpropro commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

See https://cmp.saghen.dev/modes/cmdline.html#show-menu-automatically on how to add a function for more control of when the menu actually opens.

@github-actions

github-actions Bot commented Jun 4, 2025

Copy link
Copy Markdown

🚀 Live preview deployed from cb4d834

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: fix/blink_auto_show

Reruns: 944

@itpropro

itpropro commented Jun 4, 2025

Copy link
Copy Markdown
Contributor Author

This should also apply to cmdline.completion.menu.auto_show, but the cmdline section is not really implemented yet. Should I create a separate PR for that @NotAShelf ?

@horriblename

Copy link
Copy Markdown
Collaborator

This should also apply to cmdline.completion.menu.auto_show, but the cmdline section is not really implemented yet. Should I create a separate PR for that

you can but it's not required. The point of setupOpts is so we don't have to add every plugin option out there

@NotAShelf

Copy link
Copy Markdown
Owner

Please ensure that the failing formatting checks (editorconfig and alejandra) pass before we can merge this.

github-actions Bot pushed a commit that referenced this pull request Jun 4, 2025
@itpropro

itpropro commented Jun 4, 2025

Copy link
Copy Markdown
Contributor Author

This should also apply to cmdline.completion.menu.auto_show, but the cmdline section is not really implemented yet. Should I create a separate PR for that

you can but it's not required. The point of setupOpts is so we don't have to add every plugin option out there

The problem is that this is not consistent. SetupOpts in the blink case cannot be everything, as specific things under there are overwritten by custom options like the presets. So at least the options that are implemented should allow a high amount of customization or a way to overwrite them if need to be adjusted.

@horriblename

Copy link
Copy Markdown
Collaborator

The problem is that this is not consistent. SetupOpts in the blink case cannot be everything, as specific things under there are overwritten by custom options like the presets. So at least the options that are implemented should allow a high amount of customization or a way to overwrite them if need to be adjusted.

Sorry, I don't follow, can you give an example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants