languages/clojure: init - #907
Merged
Merged
Conversation
nil-andreas
requested review from
NotAShelf,
Soliprem and
horriblename
as code owners
May 17, 2025 16:49
horriblename
requested changes
May 20, 2025
horriblename
requested changes
May 21, 2025
Co-authored-by: Ching Pei Yang <59727193+horriblename@users.noreply.github.com>
horriblename
previously approved these changes
May 26, 2025
Collaborator
|
LGTM thanks! |
Soliprem
requested changes
May 26, 2025
Co-authored-by: Soliprem <73885403+Soliprem@users.noreply.github.com>
horriblename
approved these changes
May 26, 2025
Soliprem
self-requested a review
May 27, 2025 03:58
Soliprem
approved these changes
May 27, 2025
Soliprem
left a comment
Soliprem
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Amazing work, thanks <3
|
✅ Preview has been deleted successfully! |
Owner
|
Soliprem Lisp enjoyer confirmed... |
Collaborator
|
caught me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
clojurelanguage support. I'm a Nix noob that got a lot of inspiration from the existing code in the codebase and from PR #807.I did read the comment #807 (comment) but hoping that this code might be of value when the
lsp-redesignbranch comes live. I can mark it as a draft if you want.Testing:
Tested my changes by changing the nvf url to the branch from my fork
The last lines of the buffer in the screenshot shows the current config:
Please take notice of the build results for
.#docs-htmland.#docs-linkcheck. They error:ed on clean main branch as well.Sanity Checking
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build) (ERROR:'/nix/store/6zckq3cd9pxd9x2mzdvhq006h3w3963a-nvf-manual/bin/nvf-manual': No such file or directory.#docs-linkcheck(optional, please build if adding links) (ERROR:'/nix/store/nz2qw9dmlrxas1ggq6liss0gf8xmpi0s-lychee-link-check/bin/lychee-link-check': Not a directory)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwin