Skip to content

languages/beancount: init - #1100

Merged
snoweuph merged 1 commit into
NotAShelf:mainfrom
gmvar:languages/beancount
Jul 31, 2026
Merged

languages/beancount: init#1100
snoweuph merged 1 commit into
NotAShelf:mainfrom
gmvar:languages/beancount

Conversation

@gmvar

@gmvar gmvar commented Aug 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Create the vim.languages.beancount module using bean-format and beancount-language-server.

Current Issues

  1. Formatting Behavior:
    • The beancount-language-server currently lacks an option to disable formatting. This results in documents being automatically formatted, even when the setting vim.languages.beancount.format.enable is set to false.
    • I have opened an issue on the project's GitHub repository requesting the addition of a toggle for this behavior. Until this feature is implemented, users will experience automatic formatting regardless of their preferences. GitHub Issue #650.
    • beancount-language-server added an option to disable the automatic formatting, though it's not clear to me how to enable that option... Until then, the language server will always format the document.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

github-actions Bot pushed a commit that referenced this pull request Aug 22, 2025
@actions-user
Deploy PR #1100 preview
c153c2f
@github-actions

github-actions Bot commented Aug 22, 2025 •
edited
Loading

Copy link
Copy Markdown

🚀 Live preview deployed from 9798ff4

View it here:

Debug Information

Triggered by: gmvar

HEAD at: languages/beancount

Reruns: 3847

@gmvar
gmvar force-pushed the languages/beancount branch from 0d75b65 to 8259788 Compare September 1, 2025 17:44
@gmvar
gmvar marked this pull request as ready for review September 1, 2025 17:44
github-actions Bot pushed a commit that referenced this pull request Sep 1, 2025
@actions-user
Deploy PR #1100 preview
13aa589
@gmvar
gmvar force-pushed the languages/beancount branch from 8259788 to b38da6f Compare September 4, 2025 19:47
github-actions Bot pushed a commit that referenced this pull request Sep 4, 2025
@actions-user
Deploy PR #1100 preview
ef6918c
horriblename
horriblename requested changes Sep 5, 2025
View reviewed changes
Comment thread modules/plugins/languages/beancount.nix Outdated
Comment thread modules/plugins/languages/beancount.nix Outdated
@gmvar
gmvar force-pushed the languages/beancount branch from b38da6f to fa30514 Compare September 8, 2025 23:02
github-actions Bot pushed a commit that referenced this pull request Sep 8, 2025
@actions-user
Deploy PR #1100 preview
129d364
@horriblename
horriblename force-pushed the v0.8 branch 2 times, most recently from 8b98f07 to ba9ce8b Compare September 13, 2025 07:23
@gmvar
gmvar force-pushed the languages/beancount branch from fa30514 to aade359 Compare September 26, 2025 16:25
github-actions Bot pushed a commit that referenced this pull request Sep 26, 2025
@actions-user
Deploy PR #1100 preview
23d1c04
@gmvar
gmvar requested a review from horriblename September 26, 2025 16:28
@gmvar
gmvar force-pushed the languages/beancount branch from aade359 to 25c8b76 Compare October 5, 2025 02:28
github-actions Bot pushed a commit that referenced this pull request Oct 5, 2025
@actions-user
Deploy PR #1100 preview
9d434a8
@gmvar
gmvar force-pushed the languages/beancount branch from 25c8b76 to c6e58f0 Compare October 30, 2025 17:03
github-actions Bot pushed a commit that referenced this pull request Oct 30, 2025
@actions-user
Deploy PR #1100 preview
49a03b4
NotAShelf
NotAShelf requested changes Oct 30, 2025
View reviewed changes

@NotAShelf NotAShelf left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I've meant to reply much earlier but kept forgetting each time. Two little comments before we can get this merged.

Comment thread modules/plugins/languages/beancount.nix Outdated
Comment thread modules/plugins/languages/beancount.nix Outdated
@gmvar
gmvar force-pushed the languages/beancount branch from c6e58f0 to 08caf4d Compare November 1, 2025 00:05
@gmvar
gmvar force-pushed the languages/beancount branch from 08caf4d to 82b0452 Compare November 8, 2025 19:28
github-actions Bot pushed a commit that referenced this pull request Nov 8, 2025
@actions-user
Deploy PR #1100 preview
5f2b4ec
github-actions Bot pushed a commit that referenced this pull request Jul 17, 2026
@actions-user
Deploy PR #1100 preview
6dfdc9e
@gmvar

gmvar commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

we've refactored out LSP configs from language modules in #1514

the changes needed are:

1. move the LSP definition to `vim.lsp.presets.beancount-language-server`

2. have the language module turn on the presets option

see e24630d and 7fc044d for an example

Sorry about that. The latest should be good to go I think.

horriblename
horriblename previously approved these changes Jul 17, 2026
View reviewed changes
@horriblename
horriblename enabled auto-merge July 17, 2026 08:42
@horriblename
horriblename disabled auto-merge July 17, 2026 12:37
snoweuph
snoweuph requested changes Jul 17, 2026
View reviewed changes

@snoweuph snoweuph left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

got a few small nicks related to filetypes

Comment thread modules/plugins/languages/beancount.nix Outdated
snoweuph
snoweuph reviewed Jul 17, 2026
View reviewed changes
Comment thread modules/plugins/languages/beancount.nix Outdated
snoweuph
snoweuph reviewed Jul 17, 2026
View reviewed changes
Comment thread modules/plugins/languages/beancount.nix Outdated
@gmvar
gmvar force-pushed the languages/beancount branch from 0e6b95c to c5c7fb1 Compare July 17, 2026 17:12
github-actions Bot pushed a commit that referenced this pull request Jul 17, 2026
@actions-user
Deploy PR #1100 preview
afd7829
snoweuph
snoweuph previously approved these changes Jul 17, 2026
View reviewed changes

@snoweuph snoweuph left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM youll just need to fix the CI

@gmvar
gmvar force-pushed the languages/beancount branch from c5c7fb1 to b868a0e Compare July 17, 2026 18:45
github-actions Bot pushed a commit that referenced this pull request Jul 17, 2026
@actions-user
Deploy PR #1100 preview
bb2cb30
@gmvar

gmvar commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

LGTM youll just need to fix the CI

Fixed the formatting issue.

@snoweuph

snoweuph commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

@NotAShelf you nicked this, gonna do your final review?
image

@gmvar

gmvar commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Gentle ping for a review @NotAShelf

@snoweuph

snoweuph commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

as we've released 26.07, you'll need to update which release notes you modify (26.12).

@gmvar
gmvar force-pushed the languages/beancount branch from b868a0e to 70f60f8 Compare July 31, 2026 17:46
@gmvar

gmvar commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

as we've released 26.07, you'll need to update which release notes you modify (26.12).

Fixed.

github-actions Bot pushed a commit that referenced this pull request Jul 31, 2026
@actions-user
Deploy PR #1100 preview
2aa51a8
@snoweuph

snoweuph commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

could you please run nix fmt?

@gmvar
languages/beancount: init
1971438 
Create the `vim.languages.beancount` module using `bean-format` and
`beancount-language-server`.
@gmvar
gmvar force-pushed the languages/beancount branch from 70f60f8 to 1971438 Compare July 31, 2026 17:50
@NotAShelf

NotAShelf commented Jul 31, 2026

Copy link
Copy Markdown
Owner

Sorry for the delay, and thank you for your patience :)

@snoweuph
snoweuph enabled auto-merge (rebase) July 31, 2026 17:51
@snoweuph
snoweuph merged commit a7987e9 into NotAShelf:main Jul 31, 2026
15 checks passed
@gmvar
gmvar deleted the languages/beancount branch July 31, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NotAShelf NotAShelf NotAShelf approved these changes
@horriblename horriblename horriblename left review comments
@snoweuph snoweuph snoweuph left review comments
@Soliprem Soliprem Awaiting requested review from Soliprem Soliprem is a code owner

Assignees

No one assigned

Labels

topic: documentation topic: modules topic: plugins

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gmvar @snoweuph @NotAShelf @horriblename