noresm3_0_041_cam6_4_121: Misc. bug fixes and additions#291
Conversation
- Allow build_namelist to compute this - Update sim_year to 2022 for cases with extended forcing files - Update Oslo Aero tag with some additions and bug fixes
There was a problem hiding this comment.
Hi @gold2718 , this looks fine to me. I however think that maybe we also have to change sim_year in namelist_defaults_cam.xml on various places - otherwise the 1850-2022 will nowhere be recognized.
@DirkOlivie, do you have a suggestion for what to do with files whose data ends in 2015? I have found these, there may be others: |
|
Removing |
|
Hi @gold2718, related to the updated ozone file (this is the same info as in the google-document (overview document):
|
|
Hi @gold2718, related to the CO2 surface and aircraft emission files which end in 2015 (this is the same info as in the google-document (overview document). These files can now be replaced by more recent files:
|
Remove obsolete but potentially dangerous code
|
Please have a look at my recent changes. For the Do these look correct? |
|
Other changes I would like reviewed:
|
|
@gold2718 I think it is a good idea to bring rad_climate back into the use-cases, and use the co2_cycle to distinguish between N:CO2:CO2 an A:CO2:CO2. When I looked into use-case files from the PR, it looks all fine (just in the comment section above were you list the 6 rad_climate changes, there is no CFC12 for N1850esmGhg and N1850ghg - but the code is correct). |
|
@gold2718 the changes to the aircraft and CO2 emissions files, and to the forcings (historical ozone) are also fine. |
DirkOlivie
left a comment
There was a problem hiding this comment.
Hi Steve, it all looks fine:
- the rad_climate changes
- the co2 emissions forcing changes
- the ozone field changes
Sorry, that was just a cut-and-past error from the atm_in files. Just to double-check, is it correct that CO2 is radiatively active for GHG chemistry, even for concentration-driven runs? |
|
Hi Steve, yes that is correct (CO2 is radiatively active for GHG chemistry, even for concentration-driven runs). |
Summary: Changes to radiative CO2 and diagnostic additions and bug fixes.
Contributors: @gold2718, @DirkOlivie
Reviewers: @DirkOlivie
Purpose of changes:
Github PR URL: #291
Changes made to build system: Adjustments to some use cases (see details)
Changes made to the namelist: None
Changes to the defaults for the boundary datasets: None
Substantial timing or memory changes: None
Details:
Testing:
Issues addressed by this PR: [ For each issue include a GitHub issue entry, one per line. ]