Repository navigation
fix(arima): keep seasonal period in search_arima fallback (#1276) - #1285
Open
Ajay Mathuriya (ajaycodesitbetter) wants to merge 2 commits into
Open
Ajay Mathuriya (ajaycodesitbetter) wants to merge 2 commits into
Ajay Mathuriya (ajaycodesitbetter) wants to merge 2 commits into
Conversation
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1276.
When the non-approximate refit gives infinite ic, search_arima recursed without
period, so the fallback search used the default period=1 and returned a non-seasonal model. This passesperiod=periodin that recursive call.Adds a regression test that forces the fallback and checks that the seasonal period is kept for every model fitted (fails before the fix, passes after). The full tests/test_arima.py passes locally.
Note: the failing path is rare (stepwise=False, approximation=True, exact refit fails). I forced it with a mock in the test.
I used AI assistance to help write and verify this change; I reviewed it myself.