Fix TBC 2.5.6 debuff color compatibility - #74
Open
autyan wants to merge 1 commit into
Open
Conversation
autyan
force-pushed
the
fix/tbc-20506-debuff-colors
branch
from
July 19, 2026 03:55
2da9aa0 to
711bd36
Compare
Author
|
Additional in-client semantic check on zhCN TBC Anniversary 2.5.6.68775:
This is evidence that the normal helpful-aura tuple is still compatible in 68775, but it is deliberately not presented as proof for every unit/filter combination; a target harmful sample was not captured in this run. It supports keeping this color fix independent from any broader UnitAura wrapper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TBC Anniversary 2.5.6 removed the global
DebuffTypeColortable. SUF indexes it in the aura, health, and highlight modules, so an aura update can abort and leave unit-frame content or debuffs stale.A runtime probe from zhCN client 2.5.6.68775 / Interface 20506 confirms:
DebuffTypeColor = nilUnitAura = functionDEBUFF_TYPE_NONE_COLOR,MAGIC,CURSE,DISEASE,POISON, and the newBLEEDcolor constants are tablesThe
UnitAuraobservation is an existence/type check only. It does not establish that its return tuple is semantically unchanged from 2.5.5. This PR therefore does not modify the aura query path; tuple parity should be verified separately againstC_UnitAuras.GetAuraDataByIndexbefore introducing a wrapper.Change
ShadowUF.API.GetDebuffTypeColoras a compatibility boundary instead of recreating a Blizzard global.Bleed..luacheckrc.This keeps the patch limited to the confirmed aura-color breakage and TOC metadata.
This overlaps with #73, but additionally handles
DEBUFF_TYPE_BLEED_COLOR, avoids mutating_G, makes the existingauras.lualookup safe for an unknown non-nil aura type, and passes the repository luacheck configuration with the new globals.Verification
luac -ppasses for all changed Lua files.DebuffTypeColor = nil.DebuffTypeColorentries remain authoritative.