remove outdated checks#969
Open
mikhailUshakoff wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes now-obsolete PreconfRouter-related checks from the pacaya operator flow and simplifies L1 execution layer implementations accordingly, aligning behavior with the updated contract/config expectations.
Changes:
- Removes
PreconfOperatortrait APIs related to checking TaikoWrapper’s PreconfRouter configuration and reading handover window slots. - Simplifies
Operator::get_statusby removing the TaikoWrapper PreconfRouter check and per-epoch handover window slot reload logic. - Updates Shasta/RealTime execution layers and
pacayatests to match the streamlinedPreconfOperatorinterface; bumps workspace version to1.39.3.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| shasta/src/l1/execution_layer.rs | Drops removed PreconfOperator methods from Shasta execution layer implementation. |
| realtime/src/l1/execution_layer.rs | Drops removed PreconfOperator methods from RealTime execution layer implementation. |
| pacaya/src/node/operator/tests.rs | Updates mocks/tests to match the trimmed PreconfOperator interface and removed operator behaviors. |
| pacaya/src/node/operator/status.rs | Removes duration fields tied to deleted checks. |
| pacaya/src/node/operator/mod.rs | Removes PreconfRouter configuration check and handover window slot reload logic from get_status. |
| pacaya/src/l1/traits.rs | Removes deprecated PreconfOperator trait methods. |
| Cargo.toml | Bumps workspace package version to 1.39.3. |
| Cargo.lock | Updates lockfile versions to 1.39.3. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mskrzypkows
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PreconfRouteris configured inTaikoWrappercontract.HANDOVER_WINDOWfromPreconfRoutercontract.