Remove explicit 'any' type assertions in test helpers#84
Draft
Lang-Qiu wants to merge 1 commit into
Draft
Conversation
Contributor
|
Hi @Lang-Qiu, is this PR in development? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The test file
onStopHandler.test.tscontained explicitas anytype assertions for payload objects in helper functions likecreateUserPromptSessionandcreateStopSession. This practice bypasses TypeScript's type checking, which can mask potential type errors, reduce code reliability, and deviate from TypeScript best practices for type safety.Changes
as anyassertions from thepayloadobjects increateUserPromptSessionandcreateStopSessiontest helper functions.StopPayloadandSessionDatatypes, improving type safety without altering runtime behavior.Verification
Run the existing test suite (e.g., using
npm testor equivalent) to confirm all tests pass, as these changes only affect type annotations and do not modify functionality. Additionally, verify that TypeScript compilation succeeds with strict type checking enabled.