[vgpu-manager] support custom CA certificate injection at build time#768
Conversation
Shivkumar13
force-pushed
the
custom-ca-enhancement-vgpu-manager
branch
from
53a4f02 to
a433142
Compare
|
Thanks @Shivkumar13 . Lets get rid of ubuntu20.04 changes as we don't support it. Also, we should add support in ubuntu24.04 as well. Is there a linked issue for this fix? |
|
@rahulait We don't have an issue, there is a customer case for this. I can open an issue or NVBug we want to track this. |
|
Lets open internal bug for this then and you can add me to it. I would like to understand what the issue is and get others feedback as well. |
|
@Shivkumar13 I was able to find the customer issue. Lets fix this PR by removing ubuntu20.04 change and adding support for ubuntu24.04 as well. |
Add an opt-in CUSTOM_CA_CERTS_DIR build arg to all four vGPU Manager Dockerfiles (rhel8, rhel9, ubuntu22.04, ubuntu24.04) and wire it through the Makefile build-vgpuhost-% target. Users behind a TLS-intercepting corporate proxy can drop *.crt files into vgpu-manager/<os>/certs/ and rebuild without editing the Dockerfile. The directory is empty by default, so out-of-the-box builds are unchanged. Signed-off-by: Shivkumar Ople <sople@nvidia.com>
Shivkumar13
force-pushed
the
custom-ca-enhancement-vgpu-manager
branch
from
a433142 to
27957bf
Compare
|
@rahulait done with changes, PTAL. |
rahulait
left a comment
rahulait
left a comment
There was a problem hiding this comment.
Thanks @Shivkumar13 , LGTM
|
@Shivkumar13 @rahulait Do we need to make changes for these in |
|
@tariq1890 rhel10 is not there under vgpu-manager. Maybe we should start supporting rhel10 as well? |
|
Yes, we should. Let's create a GH issue so we can track this. |
|
@tariq1890 @rahulait I have created an issue, please feel free to change the issue description if needed |
3 participants
Add an opt-in CUSTOM_CA_CERTS_DIR build arg to all four vGPU Manager Dockerfiles (rhel8, rhel9, ubuntu22.04, ubuntu24.04) and wire it through the Makefile build-vgpuhost-% target. Users behind a TLS-intercepting corporate proxy can drop *.crt files into vgpu-manager//certs/ and rebuild without editing the Dockerfile. The directory is empty by default, so out-of-the-box builds are unchanged.