fix(docker): route VM-Docker runtimes through host-gateway#1301
Open
laitingsheng wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix(docker): route VM-Docker runtimes through host-gateway#1301laitingsheng wants to merge 1 commit intoNVIDIA:mainfrom
laitingsheng wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
laitingsheng
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
laitingsheng
force-pushed
the
fix/colima-host-gateway-routing
branch
from
1ce7f9d to
7f04f05
Compare
Colima, Lima, Rancher Desktop, and OrbStack all run dockerd inside a host VM. Their bridge gateway IP is reachable from inside containers but not from the OpenShell server process running on the host, the same constraint Docker Desktop has — yet the existing is_docker_desktop check rejects them, leaving callbacks routed at a bridge IP nothing on the host can listen on. Detect these runtimes by daemon Name (Lima sets the VM hostname to colima*, lima-*, rancher-desktop, orbstack) and supplemental labels (dev.rancherdesktop.*, dev.orbstack.*), and route them through host-gateway like Docker Desktop. Signed-off-by: Tinson Lai <tinsonl@nvidia.com>
laitingsheng
force-pushed
the
fix/colima-host-gateway-routing
branch
from
7f04f05 to
b0274b2
Compare
drew
approved these changes
May 10, 2026
drew
reviewed
May 10, 2026
| } | ||
|
|
||
| if is_docker_desktop(info) { | ||
| if is_vm_dockerd_runtime(info) { |
Collaborator
There was a problem hiding this comment.
Why include "vm" here? This is just a docker (and compatible alternatives) check, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend the
host-gatewayextra-host routing branch from "Docker Desktop only" to also cover Colima, Lima, Rancher Desktop, and OrbStack — community VM-Docker runtimes that have the same constraint Docker Desktop does. Today they fall through to the bridge-gateway-IP path introduced in #1128, which leaves the supervisor callback host pointed at a bridge IP nothing on the host can bind to.Related Issue
Fixes NVIDIA/NemoClaw#1188.
Changes
crates/openshell-driver-docker/src/lib.rs: addis_vm_dockerd_runtimedetecting Colima/Lima/Rancher Desktop/OrbStack viainfo.name(Lima sets the daemon hostname) and runtime-specific label prefixes (dev.rancherdesktop.*,dev.orbstack.*); include it indocker_gateway_routealongsideis_docker_desktop.crates/openshell-driver-docker/src/tests.rs: add four routing-test cases mirroringdocker_gateway_route_uses_host_gateway_for_docker_desktop— Colima default, Colima named profile (colima-<profile>), Rancher Desktop, and OrbStack.Testing
mise run pre-commitpassesChecklist