Skip to content

test: verify import isolation from Otel SDK - #74

Merged
ahmadki merged 3 commits into
NVIDIA-NeMo:mainfrom
shangrex:test/import-isolation
Sep 28, 2026
Merged

ahmadki merged 3 commits into
NVIDIA-NeMo:mainfrom
shangrex:test/import-isolation

Conversation

@shangrex

@shangrex shangrex commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

What does this PR do?

Adds a subprocess test verifying that nemo.lens can be imported without requiring opentelemetry-sdk, preserving optional SDK dependency isolation.

Issues

None.

Usage

No user-facing usage changes. Run the focused test with:

uv run pytest -q test_import_isolation.py

Before your PR is "Ready for review"

Pre checks:

  • I read the Contributor guidelines.
  • All commits are signed off (git commit -s) per the DCO.
  • I added or updated tests under tests/ for any behavior change.
  • I ran pytest and pre-commit run --all-files locally; both pass.
  • I updated docs/ and README.md where behavior, configuration, or public API changed.
  • If this changes a lens public API symbol, I updated the cross-repo _fallbacks.py files in Megatron-LM / RL / Gym.

Additional information

Signed-off-by: rexhuang <shangjuih@nvidia.com>
@shangrex
shangrex requested a review from ahmadki as a code owner September 21, 2026 20:51
@copy-pr-bot

copy-pr-bot Bot commented Sep 21, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ahmadki

ahmadki commented Sep 23, 2026

Copy link
Copy Markdown
Member

/ok to test 6f3c2bc

@ahmadki

ahmadki commented Sep 23, 2026

Copy link
Copy Markdown
Member

/ok to test 0e61533

@ahmadki

ahmadki commented Sep 28, 2026

Copy link
Copy Markdown
Member

/ok to test 675e4c3

@ahmadki
ahmadki merged commit 3169a44 into NVIDIA-NeMo:main Sep 28, 2026
27 checks passed

This branch was successfully deployed

1 active deployment
public — 675e4c3e Deployed Sep 28, 2026 by copy-pr-bot[bot] via release / finalize / notify #151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants