fix: reuse default tracers without resetting warning deduplication - #73
Open
rhewett-nv wants to merge 1 commit into
Open
rhewett-nv wants to merge 1 commit into
rhewett-nv wants to merge 1 commit into
Conversation
Signed-off-by: Russell Hewett <rhewett@nvidia.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reuse Lens default tracers to prevent repeated OpenTelemetry SDK lookups from resetting Python warning deduplication.
OpenTelemetry SDK 1.44 changes warning filters on every get_tracer() call, allowing previously emitted warnings to print again. This change caches default tracers by provider and
instrumentation scope, resetting the cache after provider changes or process forks.
Issues
No linked issue.
Usage
No usage changes are required. Existing instrumentation automatically reuses default tracers:
from nemo.lens import span_cm
for step in range(100):
with span_cm("training.step"):
train_step()
Explicitly supplied tracers and disabled span groups retain their existing behavior.
Before your PR is "Ready for review"
Pre checks:
Additional information