-
Notifications
You must be signed in to change notification settings - Fork 12
feat: apply direct identifier replacements before rewrite LLM call #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asteier2026
wants to merge
7
commits into
main
Choose a base branch
from
asteier2026/feature/rewrite-programmatic-prereplace
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9703dda
feat: apply direct identifier replacements before rewrite LLM call
asteier2026 2f35a4b
fix: use single-pass regex to prevent cascade replacements
asteier2026 0da33e3
fix: parse sensitivity disposition only once in _get_replace_pairs
asteier2026 c439bb2
fix: fall back to whitespace-normalized match in _get_replace_pairs
asteier2026 48f897f
fix: catch exceptions in _apply_direct_replacements and fall back gra…
asteier2026 dead64e
fix: normalize Unicode whitespace when filtering replacement map entries
asteier2026 2794d19
fix:raise error if no replace
asteier2026 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_apply_direct_replacementsdocuments that it "Raises on failure rather than falling back to unmodified text", citing exactly the risk scenario: replace entities are excluded fromCOL_REWRITE_DISPOSITION_BLOCK, so a silent passthrough would emit PII with no LLM instructions. But_get_replace_pairshas two paths that return[]without raising:if not raw_map— logs a warning and returns[][])When either path fires,
pairsis empty or incomplete, theif pairs:branch is skipped,plain_text/tagged_textremain as the raw PII-containing originals, and both columns are written straight toCOL_PREREPLACE_TEXT/COL_PREREPLACE_TAGGED_TEXT. The LLM then sees unredacted PII with zero instructions to protect it. The testtest_get_replace_pairs_warns_on_unmatched_replace_entityexplicitly assertspairs == []for this path, confirming the silent-passthrough survives.Consider having
_apply_direct_replacementscomputereplace_values(or receive it from_get_replace_pairs) and raise when required pairs are missing, consistent with the documented contract.