feat: expose Data Designer run config#203
Open
lipikaramaswamy wants to merge 3 commits into
Open
Conversation
04ded89 to
b73f6d6
Compare
Contributor
Comment on lines
15
to
17
| from data_designer.config.models import ModelProvider | ||
| from data_designer.config.run_config import RunConfig | ||
| from data_designer.config.utils.io_helpers import load_config_file |
Contributor
There was a problem hiding this comment.
RunConfig is only used in the type annotation for data_designer_run_config — it is never instantiated or called at runtime. The file already uses from __future__ import annotations (PEP 563), which stringifies all annotations so the class doesn't need to be present at import time. The existing convention in this file is to put annotation-only data_designer imports under TYPE_CHECKING (see DataDesignerConfigBuilder on line 89). Moving RunConfig there avoids an unnecessary eager import of data_designer.config.run_config on every module load.
Suggested change
| from data_designer.config.models import ModelProvider | |
| from data_designer.config.run_config import RunConfig | |
| from data_designer.config.utils.io_helpers import load_config_file | |
| from data_designer.config.models import ModelProvider | |
| from data_designer.config.utils.io_helpers import load_config_file |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
9 tasks
Signed-off-by: lipikaramaswamy <lramaswamy@nvidia.com>
Signed-off-by: lipikaramaswamy <lramaswamy@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
data_designer_run_configparameter toAnonymizer(...)so callers can configure Data Designer runtime controls such asbuffer_sizeandmax_in_flight_taskswhile still using Anonymizer's normal model config/provider loading path.The name is intentionally explicit: it sits next to the existing advanced
data_designerconstructor parameter and avoids overloadingrun_config, which could be confused withAnonymizerConfigoranonymizer.run(config=...).This keeps execution/backpressure tuning on the runtime constructor instead of putting it on
AnonymizerConfig, which remains focused on anonymization behavior. The PR also re-exportsRunConfigfromanonymizerso examples can use the public Anonymizer import path.Type of Change
Testing
make testpasses locallymake checkpasses locally (format + lint + typecheck + lock-check)Targeted validation run:
uv run pytest tests/interface/test_anonymizer_interface.py -quv run ruff check src/anonymizer/interface/anonymizer.py tests/interface/test_anonymizer_interface.pyDocumentation
make docs-buildpasses locallyNo docs changed. This small API hook is intended to support self-hosted Data Designer runtime/backpressure configuration without bypassing Anonymizer's provider setup.
Related Issues