Repository navigation
chore: migrate DyldPrivate dependency to swift-dyld-private - #68
Conversation
Update package URL from MxIris-Reverse-Engineering/DyldPrivate to MxIris-Reverse-Engineering/swift-dyld-private (>=1.1.0) and drop unused DyldPrivate imports from MetadataProtocol and MetadataAccessorTests.
There was a problem hiding this comment.
Pull request overview
This PR migrates the DyldPrivate SwiftPM dependency to the renamed swift-dyld-private repository and cleans up now-unneeded module imports.
Changes:
- Update
DyldPrivatedependency URL and minimum version toMxIris-Reverse-Engineering/swift-dyld-private(from1.1.0). - Update the
package:identity used when depending on theDyldPrivateproduct. - Remove unused
import DyldPrivatefrom one source file and one test file.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Package.swift |
Points dependency resolution at swift-dyld-private and updates the product’s package: identity. |
Sources/MachOSwiftSection/Models/Metadata/MetadataProtocol.swift |
Removes an unused DyldPrivate import. |
Tests/MachOSwiftSectionTests/MetadataAccessorTests.swift |
Removes an unused DyldPrivate import from tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .target(.MachOSwiftSectionC), | ||
| .target(.Utilities), | ||
| .product(name: "DyldPrivate", package: "DyldPrivate"), | ||
| .product(name: "DyldPrivate", package: "swift-dyld-private"), |
There was a problem hiding this comment.
DyldPrivate appears to be unused across the repository now (no remaining import DyldPrivate or symbol references). If it’s no longer required, consider removing this product dependency (and the corresponding .package entry) to keep the manifest lean and avoid carrying an unnecessary transitive dependency.
| .product(name: "DyldPrivate", package: "swift-dyld-private"), |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the DyldPrivate dependency to a new repository (swift-dyld-private) and version (1.1.0). It also updates the package reference in Package.swift and removes unused import statements in MetadataProtocol.swift and MetadataAccessorTests.swift. I have no feedback to provide.
Summary
MxIris-Reverse-Engineering/DyldPrivatetoMxIris-Reverse-Engineering/swift-dyld-private(>= 1.1.0)import DyldPrivatefromMetadataProtocol.swiftandMetadataAccessorTests.swiftTest plan
swift package updateresolvesswift-dyld-private1.1.0swift buildsucceeds with 0 errors