Repository navigation
Live chain testing - #18
Merged
Merged
Conversation
SelectorLib.getFixedMaturityModuleSelectors() only routed 14 of IFixedMaturityModule's 17 functions through CoreVault. The 9 missing selectors (fundingDeadlineTs, maturityTs, minFundingAssets, fixedTermStrategy, netFundedAssets, isFundingSuccessful, isFundingTargetReached, isInstantExitOpen, finalPerformanceFeeStatus) are exactly what FixedMaturityVaultUpkeep calls through the vault proxy to drive the FM lifecycle -- the keeper was non-functional on any real FM deployment. Add the same entries to SelectorRegistry.sol, the independently-hardcoded guardrail copy that had drifted out of sync. Also fixes two deploy-script blockers found by dry-running both flows against a live Arbitrum fork: - foundry.toml had no fs_permissions write access anywhere, so _writeAddressBook()'s vm.writeJson() reverted at the last line of every script, OE and FM alike. Grant read-write on ./broadcast. - DeployFixedMaturityVault.s.sol's _seedDeadDeposit() never approved the vault before calling seedDeadDeposit(), unlike the OE script. Bring the remaining 5 standalone deploy scripts (DeployBufferManager, DeployFixedMaturityVaultUpkeep, DeployQueueModule, DeployStrategyRouter, DeployVaultUpkeep) onto ChainConfig for consistency with the rest of script/ merged in 041710c. Verified: both DeployCoreSystem and DeployFixedMaturityVault reach SIMULATION COMPLETE against a live Arbitrum fork with zero reverts; full 946-test suite green.
…bitrum migration tooling
- Zero out GlobalConfig's default minClaimAmount (was 100e6) so instant and
epoch withdrawal requests no longer strand residual balances behind an
exit floor; minDepositAmount remains the separate, unaffected deposit gate.
- Add setDefaultQueue/setVaultQueueOverride and setVaultDynamicCapOverride
so a launch vault can get epoch duration and instant-withdrawal cap
parameters scaled to its real launch cap instead of inheriting the
10M-USDC defaults.
- Replace swallowed catch {} blocks in BufferManager and StrategyRouter
with AdapterCallFailed/ExternalCallFailed events that carry the revert
reason, for adapter/strategy call failures during withdraw and rebalance.
- Wire the new overrides into DeployCoreSystem.s.sol with deploy-time
invariant checks (deposit caps, dynamic-cap threshold, epoch duration).
- Add Arbitrum GlobalConfig migration/maintenance scripts
(RedeployGlobalConfig, ConfigureWithdrawalPolicy, RunArbitrumMaintenance,
SetMinClaimAmount, WithdrawDeployerShares, GlobalConfigMigration helper,
DeployRootTimelock) plus receipts tooling and docs to correct the exit
floor on the already-deployed vault without redeploying modules.
- Cover the new config paths with GlobalConfigMigration/GlobalConfigQueue
unit tests, an adapter-isolation fork test, and Hardening_MissingTests
additions; update docs/deployment.md to match.
stefanobotticelli
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the exit-floor bug found on the live Arbitrum vault and unblocks the deploy scripts for a new launch, plus adds the migration/maintenance tooling to correct the already-deployed vault in place.
GlobalConfig's defaultminClaimAmountwas 100 USDC, so instant and epoch withdrawal requests below that were rejected — residual balances under 100 USDC were permanently stuck. Default is now 0;minDepositAmountremains the separate, unaffected deposit gate.setDefaultQueue/setVaultQueueOverrideandsetVaultDynamicCapOverridetoGlobalConfigso a launch vault gets epoch duration and instant-withdrawal cap parameters scaled to its real cap instead of inheriting the 10M-USDC defaults.BufferManagerandStrategyRouterhad emptycatch {}blocks on adapter/strategy calls (buffer withdraw/deposit, NAV reads during rebalance/redeem). Replaced withAdapterCallFailed/ExternalCallFailedevents carrying the revert reason, so these failures are observable instead of disappearing.SelectorLib/SelectorRegistryonly routed 14 of 17IFixedMaturityModulefunctions throughCoreVault; the 9 missing ones (fundingDeadlineTs,maturityTs,minFundingAssets,fixedTermStrategy,netFundedAssets,isFundingSuccessful,isFundingTargetReached,isInstantExitOpen,finalPerformanceFeeStatus) are exactly whatFixedMaturityVaultUpkeepcalls through the vault proxy — the keeper was non-functional on any real FM deployment.foundry.tomlhad nofs_permissionswrite access, so_writeAddressBook()reverted at the end of every deploy run;DeployFixedMaturityVault.s.solwas missing a vault approval beforeseedDeadDeposit(); 5 standalone scripts brought ontoChainConfigfor consistency;DeployCoreSystem.s.solnow sets explicit per-vault deposit caps and dynamic-cap overrides at deploy time with deploy-time invariant checks (deposit caps, dynamic-cap threshold, epoch duration).RedeployGlobalConfig,ConfigureWithdrawalPolicy,RunArbitrumMaintenance,SetMinClaimAmount,WithdrawDeployerShares,GlobalConfigMigrationhelper,DeployRootTimelock) plus receipts tooling and docs to correct the exit floor on the live vault without redeploying modules.GlobalConfigMigration/GlobalConfigQueueunit tests, an adapter-isolation fork test,Hardening_MissingTestsadditions, and updateddocs/deployment.md.