fix: resolve model capabilities from bundled catalog#2150
Conversation
🦋 Changeset detectedLatest commit: 38876aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca917a3a10
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Related issue
Related: #2023
Follow-up to #2036, where the model catalog review exposed that thinking profiles and general capabilities can drift independently. This also carries the capability-fallback direction from #1660 onto the current v1/v2 architecture.
@RealKai42, could you take a look since this follows the catalog/capability review in #2036?
Problem
When a configured model does not declare every capability, runtime detection can fall through to hand-maintained static matchers even though the bundled models.dev snapshot already has the metadata.
Protocol identity is not enough to choose the right catalog provider. For example, the provider in #2023 must use
type = "openai"to speak the OpenAI-compatible protocol, but its capability metadata belongs under thedeepseekprovider in models.dev. Treatingtypeas both protocol and catalog vendor either misses the metadata or requires unsafe guessing.What changed
catalog_providerto provider config. It selects the exact models.dev provider used for capability metadata without changing the API protocol selected bytype.catalog_providerwins;modelis looked up only within that provider;UNKNOWN./providerimports a catalog entry, including when the user chooses a different local provider name.google-genaiconfigurations running in Vertex mode now use thegoogle-vertexsnapshot instead of the ordinary Google snapshot.For the manual setup in #2023, adding
catalog_provider = "deepseek"selects the right metadata while keepingtype = "openai". If a gateway replaces the canonical models.dev model id with an arbitrary deployment alias, the user must continue to declare capabilities explicitly.Verification
agent-core/agent-core-v2tests passed.agent-core,agent-core-v2,node-sdk, and the CLI.agent-core-v2domain lint and config-manifest check passed.catalog_providerremains intact.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.