fix(llm): scope prompt cache keys to Moonshot APIs#2535
Open
Sanjays2402 wants to merge 1 commit into
Open
Conversation
Third-party Kimi-compatible endpoints can reject the Moonshot-specific prompt_cache_key parameter. Only attach session cache keys to known Moonshot API hosts and cover both custom and official endpoint behavior.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a compatibility regression for third-party Kimi-compatible endpoints by only sending Moonshot’s prompt_cache_key when the configured base_url points at official Kimi/Moonshot hosts, avoiding 400 “unsupported parameter” errors on providers like Nvidia NIM.
Changes:
- Add allowlisted host detection for whether
prompt_cache_keyshould be sent forkimiproviders. - Update
create_llmto includeprompt_cache_keyonly for official Kimi/Moonshot endpoints. - Add tests covering both omission for third-party endpoints and retention for official endpoints.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/kimi_cli/llm.py |
Introduces host allowlist logic and gates prompt_cache_key injection accordingly. |
tests/core/test_create_llm.py |
Adds regression tests ensuring third-party endpoints don’t receive prompt_cache_key while official endpoints still do. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+328
to
+329
| def _supports_prompt_cache_key(base_url: str) -> bool: | ||
| return urlparse(base_url).hostname in MOONSHOT_API_HOSTS |
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #2534
Description
Third-party Kimi-compatible endpoints no longer receive Moonshot's
prompt_cache_keyparameter, while official Kimi and Moonshot APIs retain session caching.Checklist
make gen-changelogto update the changelog.make gen-docsto update the user documentation.