Repository navigation
🐛 Improved logic for single join model modification #1083 - #1116
Merged
Merged
Conversation
liutao12138
approved these changes
Sep 2, 2025
ljy65535
reviewed
Sep 2, 2025
| if existing_model_by_display and existing_model_by_display["model_id"] != model_data["model_id"]: | ||
| return ModelResponse( | ||
| code=409, | ||
| message=f"Name {model_data['display_name']} is already in use, please choose another display name", |
| @@ -235,23 +235,19 @@ async def update_single_model(request: dict, authorization: Optional[str] = Head | |||
| try: | |||
| user_id, tenant_id = get_current_user_id(authorization) | |||
Contributor
There was a problem hiding this comment.
为啥测试用例里头会有接口定义，develop分支中这段代码没有地方调用，可以考虑删除
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
# Conflicts: # frontend/public/locales/en/common.json # frontend/public/locales/zh/common.json
Jasonxia007
requested changes
Sep 3, 2025
Contributor
这里的信息有些重复了，是不是考虑去掉一些？比如绿色的状态检测结果直接显示icon？
|
WMC001
reviewed
Sep 3, 2025
Jasonxia007
approved these changes
Sep 3, 2025
# Conflicts: # frontend/app/[locale]/setup/modelSetup/components/model/ModelAddDialog.tsx # frontend/app/[locale]/setup/modelSetup/components/model/ModelEditDialog.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Improved logic for single join model modification #1083