Skip to content

Fix getAssetsIndex task for ForgeGradle 1.0#1074

Closed
zeng-github01 wants to merge 1 commit into
MinecraftForge:FG_1.0from
zeng-github01:FG_1.0-assets-download
Closed

Fix getAssetsIndex task for ForgeGradle 1.0#1074
zeng-github01 wants to merge 1 commit into
MinecraftForge:FG_1.0from
zeng-github01:FG_1.0-assets-download

Conversation

@zeng-github01
Copy link
Copy Markdown

Changes

  • Asset Download Fix:
    • Replaced the legacy asset downloading logic with the current Mojang API implementation.
    • This fix is backported and adapted from anatawa12/ForgeGradle-1.2.

Testing Performed

  • Executed `./gradlew build and successfully

@LexManos
Copy link
Copy Markdown
Member

Did some quick tests couple days ago and it didnt work on my end.
I've been working on a solution to things related to this. So keep an eye out.

@zeng-github01
Copy link
Copy Markdown
Author

zeng-github01 commented May 14, 2026

Did some quick tests couple days ago and it didnt work on my end. I've been working on a solution to things related to this. So keep an eye out.

I see, thanks.

I am still using the previous fixed version. However, I recently encountered an issue; since I am not familiar with FG, I haven't been able to figure out what caused it.

When executing the setup Workspace task, the index json file fails to be retrieved, indicating that the file does not found. However, the build task retrieves the json file successfully, and the former no longer throws errors after execution.

@LexManos
Copy link
Copy Markdown
Member

Depends on what you mean by index json, thats the thing, a lot of stuff has changed in the last 15 years. So you'd need to be more descriptive.

@zeng-github01
Copy link
Copy Markdown
Author

zeng-github01 commented May 18, 2026

Depends on what you mean by index json, thats the thing, a lot of stuff has changed in the last 15 years. So you'd need to be more descriptive.

This has now been fixed. When backporting the changes based on the reference patch, I hadn't fully grasped the specific implications of the modifications. I now understand them clearly, so I have revised the patch accordingly.

I did not correctly understand the logic flow of the new Assets Download feature. I mistakenly modified the newly added constants, which resulted in conflicts across several JSON files.

The revised patch has been force-pushed to my FG1.0-fix branch.

It's a good thing you didn't merge that previous PR.

@LexManos
Copy link
Copy Markdown
Member

Ah, well glad you got something working for your side.
Hadn't looked too deeply into your code, just ran it, it failed, and so got back to work on FG7.
Been sick the last few days, so progress has been slow, but progressing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants