feat: add assets domain skills - #131
Merged
Merged
Conversation
- Introduced a new section in the README.md for the `assets` domain, outlining its skills and purpose within the MM product engineering team. - Added a new skill documentation file for `acceptance-criteria-doc`, detailing the process for generating acceptance criteria documents for Jira epics, including structure, inputs, and workflow. - Created a new skill documentation file for `react-compiler-migration`, providing guidelines for migrating files to optimize them for the React Compiler. - Added a reference patterns document for `react-compiler-migration`, containing validated patterns for common compiler issues and their solutions. - Updated CODEOWNERS to include the new `assets` domain for better ownership tracking.
Prithpal-Sooriya
enabled auto-merge (squash)
August 18, 2026 16:51
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Refined this, see examples here:
MetaMask/metamask-mobile#34895
salimtb
reviewed
Aug 19, 2026
salimtb
reviewed
Aug 19, 2026
Start the skill at experimental until it has been run outside Assets, per review feedback. Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
Start the skill at experimental until it has been run outside Assets, per review feedback. Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
salimtb
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Initial setup for @MetaMask/metamask-assets skills.
Type of Change
Skill Details (if adding a new skill)
Provider Name: Assets
Skill Name & Desc:
Checklist
Testing
Additional Context