feat(stellar-wallet-snap): attach optional memo on confirmSend build flow - #289
Draft
khanti42 wants to merge 10 commits into
Draft
feat(stellar-wallet-snap): attach optional memo on confirmSend build flow#289khanti42 wants to merge 10 commits into
khanti42 wants to merge 10 commits into
Conversation
…t and refactoring
…and attach resolved Stellar memos on send build path
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Explanation
Context: WPN-2033 / WPN-2035 — first slice of Stellar memo support for Unified Non-EVM Send. Snap-only (no extension memo field in this PR).
Problem:
confirmSendcould not attach a Stellar memo to the built envelope. Exchange-style numeric memos needMemo.id; free-text needsMemo.text(≤ 28 UTF-8 bytes).Solution: Optional
memo/memoTypeonconfirmSend.resolveStellarMemomaps explicit type, else all-digit uint64 →Memo.id, elseMemo.text. Wired through TransactionBuilder / TransactionService / confirmation transaction refresh. No UI, no RequiresMemo recovery.Out of scope (follow-ups): Snap Add/Update memo UI + recoverable RequiresMemo (WPN-2034 / WPN-2036); dialog XDR handoff (WPN-2039); muxed (WPN-2037).
Note: When
memoTypeis omitted, all-digit values becomeMemo.id(Freighter-style). Digits intended as text must passmemoType: "text".References
Checklist
memotoday)