Zipper via Reranker. Load more. Result numbers. by JPrevost · Pull Request #448 · MITLibraries/timdex-ui

JPrevost · 2026-08-03T21:16:41Z

This pull request introduces our Reranker gem, but keeps the Zipper merge default. This sets us up for future algorithms, but allows us to separate this structural change from algorithm selection.

It also reworks pagination to be load more that relies heavily on a new redis cache approach. This is quite a bit simpler than our initial approach because we are dropping support for jumping to arbitrary pages.

It also introduces a first pass at reintroducing result numbers. A separate ticket has been created and assigned to Dave to adjust as needed and ensure it works well in mobile sized viewports.

It tried to break this into separate PRs, but failed.

Developer

Accessibility

ANDI or WAVE has been run in accordance to our guide.
This PR contains no changes to the view layer.
New issues flagged by ANDI or WAVE have been resolved.
New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
No new accessibility issues have been flagged.

New ENV

All new ENV is documented in README.
All new ENV has been added to Heroku Pipeline, Staging and Prod.
ENV has not changed.

Approval beyond code review

UXWS/stakeholder approval has been confirmed.
UXWS/stakeholder review will be completed retroactively.
UXWS/stakeholder review is not needed.

Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code

I have confirmed that the code works as intended.
Any CodeClimate issues have been fixed or confirmed as
added technical debt.

Documentation

The commit message is clear and follows our guidelines
(not just this pull request message).
The documentation has been updated or is unnecessary.
New dependencies are appropriate or there were no changes.

Testing

There are appropriate tests covering any new functionality.
No additional test coverage is required.

coveralls · 2026-08-03T21:18:39Z

Coverage Report for CI Build 30911640308

Coverage decreased (-0.06%) to 98.265%

Details

Coverage decreased (-0.06%) from the base build.
Patch coverage: 1 uncovered change across 1 file (126 of 127 lines covered, 99.21%).
No coverage regressions found.

Uncovered Changes

File	Changed	Covered	%
app/models/merged_search_service.rb	101	100	99.01%
Total (2 files)	127	126	99.21%

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	1556
Covered Lines:	1529
Line Coverage:	98.26%
Coverage Strength:	81.91 hits per line

💛 - Coveralls

qltysh · 2026-08-03T21:18:50Z

❌ 26 blocking issues (33 total)

Tool	Category	Rule	Count
rubocop	Lint	Unused block argument - `query`. If it's necessary, use `\_` or `\_query` as an argument name to indicate that it won't be used.	9	❌
rubocop	Lint	Method has too many lines. [25/10]	6	❌
rubocop	Lint	Assignment Branch Condition size for `results` is too high. [<6, 33, 8> 34.48/17]	5	❌
rubocop	Lint	Class has too many lines. [340/100]	2	❌
rubocop	Lint	Cyclomatic complexity for `results` is too high. [8/7]	1	❌
rubocop	Lint	Avoid parameter lists longer than 5 parameters. [6/5]	1	❌
rubocop	Lint	Duplicate branch body detected.	1	❌
rubocop	Lint	Rename `has\_more?` to `more?`.	1	❌
qlty	Structure	Function with many parameters (count = 4): ensure_ordered_results	4
qlty	Structure	Function with high complexity (count = 6): ensure_ordered_results	2
qlty	Structure	Function with many returns (count = 4): exhaustion_reason	1

qltysh · 2026-08-03T21:18:52Z

      format.json { render json: { results: @results, pagination: @pagination, errors: @errors } }
+      format.turbo_stream { render :results }
      format.html { render :results }
    end


Found 3 issues:

1. Assignment Branch Condition size for results is too high. [<6, 33, 8> 34.48/17] [rubocop:Metrics/AbcSize]

2. Cyclomatic complexity for results is too high. [8/7] [rubocop:Metrics/CyclomaticComplexity]

3. Method has too many lines. [25/10] [rubocop:Metrics/MethodLength]

qltysh · 2026-08-03T21:18:52Z

    @results = NormalizeTimdexResults.new(raw_results, @enhanced_query[:q]).normalize
    @filters = extract_filters(response)
+    @append_results = @results
+    @load_more = load_more_from_pagination(@pagination)


Found 2 issues:

1. Assignment Branch Condition size for load_geodata_results is too high. [<10, 14, 2> 17.32/17] [rubocop:Metrics/AbcSize]

2. Method has too many lines. [11/10] [rubocop:Metrics/MethodLength]

qltysh · 2026-08-03T21:18:52Z

    @errors = data[:errors]
-    @pagination = data[:pagination]
-    @show_primo_continuation = data[:show_primo_continuation]
+    @load_more = data[:load_more]


Found 2 issues:

1. Assignment Branch Condition size for load_all_results is too high. [<14, 14, 0> 19.8/17] [rubocop:Metrics/AbcSize]

2. Method has too many lines. [13/10] [rubocop:Metrics/MethodLength]

qltysh · 2026-08-03T21:18:52Z

+  def combine_errors(*error_arrays)
+    all_errors = error_arrays.compact.flatten
+    all_errors.any? ? all_errors : nil
  end


Class has too many lines. [172/100] [rubocop:Metrics/ClassLength]

qltysh · 2026-08-03T21:18:52Z

+        has_more: has_more?(state, display_count),
+        total_hits: total_hits
+      }
+    }


Found 2 issues:

1. Assignment Branch Condition size for fetch is too high. [<9, 28, 4> 29.68/17] [rubocop:Metrics/AbcSize]

2. Method has too many lines. [22/10] [rubocop:Metrics/MethodLength]

qltysh · 2026-08-03T21:18:53Z

+      ].slice(offset, per_page) || []
+      { results: results, hits: 4, errors: nil, show_continuation: false }
+    end
+    timdex_fetcher = lambda do |offset:, per_page:, query: nil|


Unused block argument - query. If it's necessary, use _ or _query as an argument name to indicate that it won't be used. [rubocop:Lint/UnusedBlockArgument]