Skip to content

Introduce scores to API responses - #444

Merged
JPrevost merged 1 commit into
mainfrom
use-654-add-scores
Aug 3, 2026
Merged

Introduce scores to API responses#444
JPrevost merged 1 commit into
mainfrom
use-654-add-scores

Conversation

@JPrevost

@JPrevost JPrevost commented Jul 31, 2026

Copy link
Copy Markdown
Member

Why are these changes being introduced:

  • Scores will be useful in reranking results in the near future

Relevant ticket(s):

How does this address that need:

  • GraphQL queries now request scores
  • Scores are now normalized into the records for both TIMDEX and Primo

Document any side effects to this change:

  • Cassettes regeneration for TIMDEX cassettes

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@qltysh

qltysh Bot commented Jul 31, 2026

Copy link
Copy Markdown

❌ 6 blocking issues (6 total)

Tool Category Rule Count
rubocop Lint Class has too many lines. [249/100] 2
rubocop Lint Assignment Branch Condition size for normalize is too high. [<0, 24, 0> 24/17] 2
rubocop Lint Method has too many lines. [26/10] 2

@mitlib
mitlib temporarily deployed to timdex-ui-pi-use-654-ad-4sl5j0 July 31, 2026 16:49 Inactive
Why are these changes being introduced:

* Scores will be useful in reranking results in the near future

Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/USE-654

How does this address that need:

* GraphQL queries now request scores
* Scores are now normalized into the records for both TIMDEX and Primo

Document any side effects to this change:

* Cassettes regeneration for TIMDEX cassettes
@JPrevost
JPrevost force-pushed the use-654-add-scores branch from 4e14764 to 40dc79a Compare August 3, 2026 17:25
@JPrevost
JPrevost temporarily deployed to timdex-ui-pi-use-654-ad-4sl5j0 August 3, 2026 17:25 Inactive
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 30836690009

Coverage decreased (-0.06%) to 98.326%

Details

  • Coverage decreased (-0.06%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (4 of 5 lines covered, 80.0%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
app/models/normalize_primo_record.rb 3 2 66.67%
Total (2 files) 5 4 80.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1553
Covered Lines: 1527
Line Coverage: 98.33%
Coverage Strength: 85.94 hits per line

💛 - Coveralls

@JPrevost
JPrevost merged commit 98236da into main Aug 3, 2026
6 checks passed
@JPrevost
JPrevost deleted the use-654-add-scores branch August 3, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants