Configurable price format + build/dependency updates - #3
Merged
Conversation
Replace the hardcoded locale currency NumberFormat with a `price-format-pattern` setting under post-settings, so the currency symbol (and grouping/decimal style) can be changed via config. Falls back to `$#,##0.00` when unset, so existing configs are unaffected. Uses Locale.ROOT symbols so output does not shift with the server JVM locale. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Wrapper 9.0 -> 9.6.1, shadow 9.3.1 -> 9.6.1, run-paper 2.3.0 -> 3.0.2. Dependencies: - VaultAPI 1.7 -> 1.7.1 - mariadb-java-client 3.4.0 -> 3.5.10 (also in plugin.yml libraries) - HikariCP 5.1.0 -> 7.1.0 (also in plugin.yml libraries) - configurate-yaml/gson 4.1.2 -> 4.2.0 - cloud-paper 2.0.0-beta.10 -> 2.0.0 - cloud-annotations 2.0.0 -> 2.1.0 - junit-bom 5.10.2 -> 6.1.2 paper-api is deliberately left at 1.21.8-R0.1-SNAPSHOT. Swapped junit-vintage-engine for junit-platform-launcher: JUnit 6 needs the launcher on the test runtime classpath and there are no JUnit 4 tests. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…ce-format # Conflicts: # src/main/java/io/github/md5sha256/democracypost/PostSettings.java # src/main/resources/settings.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurable price format
Replaces the hardcoded
NumberFormat.getCurrencyInstance()inPostOfficeMenuwith aprice-format-patternsetting underpost-settings, so the currency symbol (and grouping/decimal style) can be changed via config.It is a standard
java.text.DecimalFormatpattern, so any literal text around the number is kept verbatim:#,##0.00 credits, and so on.$#,##0.00when unset or empty, so existing configs are unaffected.Locale.ROOTsymbols so output does not shift with the server JVM locale.Version bumped
1.0.1-SNAPSHOT->1.1.0-SNAPSHOT(new backward-compatible config option).Build / dependency updates
Gradle wrapper
9.0->9.6.1, shadow9.3.1->9.6.1, run-paper2.3.0->3.0.2.The mariadb and HikariCP versions in
plugin.ymllibraries:were updated to match. HikariCP 7.x requires Java 17+, which is fine against the Java 21 target.paper-apiis deliberately left at1.21.8-R0.1-SNAPSHOT.junit-vintage-enginewas swapped forjunit-platform-launcher: JUnit 6 needs the launcher on the test runtime classpath, and there are no JUnit 4 tests. Happy to restore vintage if you want it kept for future use.de.themoep:inventorygui:1.6.1-SNAPSHOTwas left alone; the version check could not resolve metadata for it.Testing
./gradlew buildpasses,TestMariaSchema(1 test) passes,shadowJarproduces the relocated jar.🤖 Generated with Claude Code