feat(roles/alternatives): support subcommands and family, ensure tooling is installed#259
Open
markuslf wants to merge 1 commit into
Open
feat(roles/alternatives): support subcommands and family, ensure tooling is installed#259markuslf wants to merge 1 commit into
markuslf wants to merge 1 commit into
Conversation
…ing is installed Pass through the module's `subcommands` (slaves/followers) and the Red Hat-only `family` option, and switch `link`/`path`/`priority` to default(omit) so the module applies its own defaults. Ensure the alternatives tooling is installed: `chkconfig` on RHEL 8, `alternatives` on RHEL 9/10 (via per-version vars + shared platform-variables); on Debian/Ubuntu it ships with dpkg, so nothing is installed there. Make `alternatives__alternatives` optional with a default of [] (no-op include), and document the new subkeys and behavior in the README and argument_specs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enhances the
alternativesrole to use more of thecommunity.general.alternativesmodule and to be self-sufficient regarding its tooling.Changes
subcommands(slaves/followers, community.general 5.1.0+) andfamily(Red Hat-family only, 10.1.0+) are now passed through, viadefault(omit).link/path/priorityswitched todefault(omit)so the module applies its own defaults (e.g. priority50on creation) andpathis not forced onstate: absent.chkconfigon RHEL 8,alternativeson RHEL 9/10 (per-versionvars/+sharedplatform-variables). On Debian/Ubuntuupdate-alternativesships withdpkg, so nothing is installed there.alternatives__alternativesis now optional with a default of[](a no-op include); README moved it to Optional Role Variables and documents the new subkeys.subcommands/family/absentexample);meta/argument_specs.ymlextended.Debugtask is kept.Verification
subcommandsrun end-to-end on Rocky 9 and Debian 12 (master + slave links created,failed=0).chkconfig, RHEL 9/10alternatives, Debian/Ubuntudpkg.Compatibility
No
COMPATIBILITY.mdchange: this adds features, not new platform support. The supported set is unchanged.