Skip to content

EnsembleSeries.quantiles(): name common_time() in the mismatched-axes error #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaibhav8a wants to merge 1 commit into
base: master
Choose a base branch
from
Open

EnsembleSeries.quantiles(): name common_time() in the mismatched-axes error #706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pyleoclim/core/ensembleseries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,10 @@ def quantiles(self, qs=[0.05, 0.5, 0.95], axis = 'value'):
vals = []
for ts in self.series_list:
if not np.array_equal(ts.time, time):
raise ValueError('Time axis not consistent across the ensemble!')
raise ValueError(
'Time axis not consistent across the ensemble! '
'Apply common_time() first to place all members on a shared time axis.'
)

vals.append(ts.value)

Expand Down
12 changes: 12 additions & 0 deletions pyleoclim/tests/test_core_EnsembleSeries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,18 @@ def test_quantiles_t0(self):

ens_qs = ts_ens.quantiles()

def test_quantiles_mismatched_time_axes(self):
"""axis='value' requires a shared time axis; the error must name the fix"""
nt = 50
t, v = pyleo.utils.gen_ts(model="colored_noise", nt=nt, alpha=1.0)
base = pyleo.Series(t, v, verbose=False)
shifted = pyleo.Series(t + 1, v, verbose=False)

ts_ens = pyleo.EnsembleSeries([base, shifted])

with pytest.raises(ValueError, match="common_time"):
ts_ens.quantiles(axis="value")

def test_quantiles_t1(self):

nn = 30 # number of age models
Expand Down