Skip to content

chore(ci): ruff py310 target, ruff-action, uvx pre-commit & fix uv build#483

Open
bhimrazy wants to merge 8 commits into
Lightning-AI:mainfrom
bhimrazy:chore/ruff-py310-target
Open

chore(ci): ruff py310 target, ruff-action, uvx pre-commit & fix uv build#483
bhimrazy wants to merge 8 commits into
Lightning-AI:mainfrom
bhimrazy:chore/ruff-py310-target

Conversation

@bhimrazy

@bhimrazy bhimrazy commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

  • Bumps ruff target-version to py310 in pyproject.toml and applies the resulting pyupgrade auto-fixes (Optional[X]X | None, Union[X, Y]X | Y, Callable from collections.abc)
  • Adds a new reusable check-ruff.yml workflow using astral-sh/ruff-action@v3 with --output-format=github for inline PR annotations
  • Simplifies pre-commit run step: uv pip install pre-commit && pre-commituvx pre-commit
  • Fixes pkg-create action: replaces python -m build with uv build to avoid No module named pip error in uv venvs (uv venvs don't include pip; build 1.4 bootstraps its isolated env via pip --python which fails)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

…mmit

- Set ruff target-version to py310 in pyproject.toml
- Add check-ruff.yml reusable workflow using astral-sh/ruff-action@v3
  with --output-format=github for inline PR annotations
- Simplify pre-commit run step to use uvx pre-commit
@github-actions github-actions Bot added ci/cd Continuous integration and delivery package labels Mar 25, 2026
@github-actions github-actions Bot added the tests label Mar 25, 2026
@codecov

codecov Bot commented Mar 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@5646a0d). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             main   #483   +/-   ##
=====================================
  Coverage        ?    72%           
=====================================
  Files           ?     17           
  Lines           ?    749           
  Branches        ?      0           
=====================================
  Hits            ?    540           
  Misses          ?    209           
  Partials        ?      0           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

uv venvs don't include pip by default; build v1.4 bootstraps its isolated
env via `pip --python` which fails with "No module named pip". Using
uv build bypasses pip entirely and is consistent with the uv-based stack.
@bhimrazy bhimrazy changed the title chore(ci): bump ruff target to py310, add ruff-action, use uvx pre-co… chore(ci): ruff py310 target, ruff-action, uvx pre-commit & fix uv build Mar 25, 2026
@Borda Borda enabled auto-merge (squash) April 21, 2026 08:06
@bhimrazy bhimrazy disabled auto-merge May 26, 2026 07:56
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@bbe3025). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##             main   #483   +/-   ##
=====================================
  Coverage        ?    72%           
=====================================
  Files           ?     17           
  Lines           ?    749           
  Branches        ?      0           
=====================================
  Hits            ?    540           
  Misses          ?    209           
  Partials        ?      0           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd Continuous integration and delivery package tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants