Handle missing products without a type error - #3
Draft
pH-7 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A missing product currently returns
falsefrom PDO through astdClassreturn type, raising a TypeError before the controller can redirect. Returnnullfor an absent row while preserving existing product data.Validation: a real in-memory SQLite regression reproduces the original error; both missing/existing-product tests pass after the fix using isolated PHPUnit 9.6 on PHP 8.5. All 30 original PHP files pass syntax checks. Existing nullable-parameter deprecation warnings remain.
The full legacy PHPUnit suite cannot run: Composer blocks the configured Twig 2 and Symfony 4 dependencies due to security advisories. No dependency migration or deployment is included; this PR remains a draft pending integration validation.