Repository navigation
VK_EXT_ray_tracing_invocation_reorder: Fix swapped HLSL instance mapping - #2833
Merged
Merged
Conversation
The HLSL mapping paired HitObject::GetInstanceID with OpHitObjectGetInstanceIdEXT and HitObject::GetInstanceIndex with OpHitObjectGetInstanceCustomIndexEXT by name, which is backwards. HLSL's InstanceID() is the application specified 24-bit value (InstanceCustomIndexKHR, gl_InstanceCustomIndexEXT) while InstanceIndex() is the index of the instance in the TLAS (the InstanceId BuiltIn, gl_InstanceID), which is what OpHitObjectGetInstanceIdEXT returns per GLSL_EXT_shader_invocation_reorder.
Contributor
|
I checked the new mapping against independent sources and it holds up:
So I also built the proposal with asciidoctor with the patch applied. There are no warnings, and both ▎ GenAI disclosure: Analysis assisted by Claude (claude-sonnet-5-5, Anthropic, commercial SaaS — Claude Code CLI). |
dgkoch
approved these changes
Oct 22, 2026
dgkoch
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Signed off by the Ray TSG 10/22
oddhack
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-created #2831 to actually be reviewed, this time without accidental insta-merge.
The HLSL mapping paired HitObject::GetInstanceID with OpHitObjectGetInstanceIdEXT and HitObject::GetInstanceIndex with OpHitObjectGetInstanceCustomIndexEXT by name, which is backwards. HLSL's InstanceID() is the application specified 24-bit value (InstanceCustomIndexKHR, gl_InstanceCustomIndexEXT) while InstanceIndex() is the index of the instance in the TLAS (the InstanceId BuiltIn, gl_InstanceID), which is what OpHitObjectGetInstanceIdEXT returns per GLSL_EXT_shader_invocation_reorder.