Make new name creation only dependent on goal namespaces not on global counter#3848
Merged
Conversation
FliegendeWurst
approved these changes
Jun 19, 2026
FliegendeWurst
left a comment
FliegendeWurst
left a comment
Member
There was a problem hiding this comment.
The fix looks good to me.
Though I could not come up with an example where the freeName counter logic is applied. I tried naming a variable k_before and nesting two loops which assign the same variable. In both cases the baseName is used as is.
WolframPfeifer
approved these changes
Jun 19, 2026
WolframPfeifer
left a comment
WolframPfeifer
left a comment
Member
There was a problem hiding this comment.
I tested it a bit in the GUI, and it really looks like it fixes the bug. Also, the test case is a good idea. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
This pull request resolves #3834, #3847 hopefully
.
Intended Change
New names are allocated only based on the goals namespace and the already reserbed names
(the varcond creates more than one name, so we have to consider them to not cause a clash).
This makes it independent of double checking (which caused before this PR a global counter variable to be modifed, and hence the breaking side-effect)
Type of pull request
Ensuring quality
Additional information and contact(s)
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.