Repository navigation
fix(windows-memory): classify pages after masking protection modifiers - #706
Merged
Merged
Conversation
Mask the page-protection modifier bits before classifying, so readable pages carrying PAGE_NOCACHE or PAGE_WRITECOMBINE are scanned. Guard, no-access, and execute-only pages stay excluded. Log per-process region counts that separate excluded regions from failed reads. Closes #613
Commit private pages with PAGE_NOCACHE and PAGE_WRITECOMBINE, and guard and no-access pages, then assert by address whether the reader returns them.
Owner
Author
|
Windows VM check done on lab-windows: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #613
Changes
src/memory/protection.rs: masks the base protection (low byte) from the modifier bits, then classifies. Guard is checked first, then no-access, then readable bases. Pureu32logic, so the unit tests run on every host.src/memory/windows.rsuses it in place of the exact-matchis_readable/is_writable/is_executable.eligible,excluded_protection,excluded_kind(never read) versusread_failed.docs/configuration.mddocuments which committed Windows regions are scanned.Testing
PAGE_NOCACHE,PAGE_WRITECOMBINE, andPAGE_TARGETS_INVALID; guard excluded for every base; no-access and execute-only excluded.cargo test --lib memory::passes on macOS;cargo clippy --target x86_64-pc-windows-gnu --all-targets -- -D clippy::allis clean.