Fix packaging on Linux - #5686
Conversation
| with(aotProject(AotMode.None, javaVendor = JvmVendor.KnownJvmVendor.AMAZON, javaVersion = 17)) { | ||
| // fun testRunTask(runTask: String) { | ||
| // gradleFailure(runTask).checks { | ||
| // check.logContains("AotMode 'AppCdsAuto' is not supported on JDK earlier than 19; current is 17") | ||
| // } | ||
| // } | ||
| gradle(":packageReleaseDmg") | ||
|
|
||
| // testRunTask(":runReleaseDistributable") | ||
| } | ||
| } |
There was a problem hiding this comment.
could you explain this?
There was a problem hiding this comment.
Generally I'd recommend to avoid such heavy tests. Instead we need to check a task configuration only
There was a problem hiding this comment.
Remnants from ancient times; removed.
There was a problem hiding this comment.
Generally I'd recommend to avoid such heavy tests. Instead we need to check a task configuration only
It tests failure, so should pass (fail) quickly.
a142a75
into
master
Alexander Maryanovsky (@m-sasha) was it broken in 1.12? |
If I understand correctly, 1.12.10-alpha01+dev4534 is not actually 1.12 |
|
Alexander Maryanovsky (@m-sasha) it seems not a part of any release, so we do not need to write release notes in this case. Could you please remove it to avoid user's confusion? |
I marked it as (prerelease fix); is that enough? |
|
(prerelease fix) is only for cases where we're fixing something that was released as alpha/beta. |
|
Ok, removed |
3 participants
Pass
--app-imageand--iconcorrectly.Before #5644 the packaging for Linux was done in one step. Now the packaging is always done in two steps: first create an "app image" and then from that an installer.
The packaging task was not set up correctly for this (on Linux).
Fixes https://youtrack.jetbrains.com/issue/CMP-10546
Testing
Tested manually and added a check in a unit test
Release Notes
N/A