Add Core Keeper game support - #47
Merged
Merged
Conversation
Add Wuthering Waves, Neverness to Everness, Blue Protocol: Star Resonance, and Harry Potter: Magic Awakened to the game selection list in the bug report issue template, allowing users to report issues for these titles. Quote entries containing colons to ensure valid YAML.
Update the multi-game support feature list to include Neverness to Everness, Blue Protocol: Star Resonance, and Harry Potter: Magic Awakened.
Register Core Keeper in the game registry with process detection and location/active-state settings. Add six instruments (Pocket Piano, Cello, Drumkit, Flute, Harp, Ocarina) sharing a 24-key chromatic C3-B4 QWERTY layout, and add the game icon.
List Core Keeper instruments, refresh the multi-game feature line to cover all registered games, add a ban-risk note for Core Keeper, and credit Pugstorm/Core Keeper in trademark attributions.
Add Core Keeper to the game selection list in the bug report issue template.
Mirror CoreKeeperLocation and ActiveCoreKeeper in the userSettings section like every other game, matching the Settings.settings defaults.
Each Core Keeper instrument sounds in its own octave range over the shared 24-key layout: Drumkit/Cello C2-B3, Harp/Pocket Piano C3-B4, Flute C4-B5, Ocarina C5-B6. Top row plays the upper octave, bottom row the lower. Update layout docs and README accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #46
What does this PR do?
Adds Core Keeper as a supported game, following the existing multi-game structure (
GameRegistry+ per-game instruments/layouts/settings).Changes
Game support
GameRegistrywith process detection (CoreKeeper) and per-game location / active-state settingsCoreKeeperLocationandActiveCoreKeeperuser settings, including the default mirrors inApp.configCore/Games/CoreKeeper/Instruments/, mirroring the Heartopia structureq2w3er5t6y7u, bottom rowzsxdcvgbhnjm). Each instrument sounds in its own octave range: Drumkit/Cello C2–B3, Harp/Pocket Piano C3–B4, Flute C4–B5, Ocarina C5–B6 (top row = upper octave, bottom row = lower octave)Docs & housekeeping
Testing
dotnet buildpasses with 0 errorsdotnet format --verify-no-changesclean on all touched C# filesCoreKeeper) verified from Task Manager with the Steam version runningTested with Core Keeper
v1.2.1.5(Steam), Windows 11.Demo videos (per instrument)
Each video shows a MIDI file played by Auto MIDI Player into the corresponding in-game instrument:
Notes for reviewers
AutoMidiPlayer.WPF.Core.Instrumentsnamespace, so no central registration list needed updating7.11.4→7.12.0, matching how previous game additions were versioned — e.g. Harry Potter: Magic Awakened bumped7.7.0→7.8.0in its support commit), but I'd rather leave versioning decisions to you. Happy to bump it if you'd like — just let me know!docs: update .NET version to 10.0 and fix license file references) — happy to rebase it out if you'd prefer to keep this PR game-onlyHappy to adjust anything — mapping, instrument structure, or docs wording. Thanks for the great project! 💖