feat: add Wuthering Waves support - #45
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The changes follow existing registry/instrument/layout patterns, appear consistent with current conventions, and introduce no verified functional or integration issues in the reviewed diffs.
Pull request overview
Adds “Wuthering Waves” as a first-class supported game, wiring it into the existing dynamic game/instrument/layout discovery and settings persistence model used across Auto MIDI Player.
Changes:
- Registers Wuthering Waves in
GameRegistrywith process detection, activation toggle, saved location, and a pack URI icon reference. - Introduces a 21-key QWERTY keyboard layout and a matching 21-note diatonic instrument config for Wuthering Waves.
- Updates persisted user settings (settings schema + designer + app config) and documents support/safety/trademark notes in the README.
File summaries
| File | Description |
|---|---|
| README.md | Documents Wuthering Waves support, safety link, and trademark disclaimer update. |
| AutoMidiPlayer.WPF/Core/Games/WutheringWaves/KeyboardLayout.cs | Adds the 21-key QWERTY key layout definition for Wuthering Waves. |
| AutoMidiPlayer.WPF/Core/Games/WutheringWaves/Instruments/Instrument.cs | Adds the 21-key instrument note mapping and associates it with the QWERTY layout. |
| AutoMidiPlayer.WPF/Core/Games/GameRegistry.cs | Registers Wuthering Waves as a supported game (settings-backed location/activation + process name). |
| AutoMidiPlayer.Data/Properties/Settings.settings | Adds WutheringWavesLocation and ActiveWutheringWaves user settings. |
| AutoMidiPlayer.Data/Properties/Settings.Designer.cs | Adds strongly-typed accessors for the new Wuthering Waves settings. |
| AutoMidiPlayer.Data/App.config | Adds default values for the new Wuthering Waves settings. |
Review details
Files not reviewed (1)
- AutoMidiPlayer.Data/Properties/Settings.Designer.cs: Generated file
- Files reviewed: 6/8 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Jed556
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Wuthering Waves support with its shared 21-key QWERTY instrument layout.
Q W E R T Y UA S D F G H JZ X C V B N MProcess detection and compatibility
Tested on the CN client installed through the official launcher.
Tested executable:
Wuthering Waves Game\Client\Binaries\Win64\Client-Win64-Shipping.exeThe registered process name is
Client-Win64-Shipping. Auto MIDI Player also derives a process name from the executable selected in Settings, allowing a user to configure another regional client manually if its filename differs.The international client has not been tested directly. Public references currently show the same executable for other distributions:
Validation
The builds retain existing upstream warnings, including the current
SQLitePCLRaw.lib.e_sqlite3advisory; this PR introduces no Wuthering Waves-specific build warnings and intentionally does not mix dependency cleanup into the game-support change.Known limitations / review requested
Versioning
The project version is intentionally unchanged so release versioning remains under maintainer control. I can update it if preferred.
Closes #44