Skip to content

fix(ci): set test_path so the build test actually runs the tests - #69

Draft
openvoiceos-bot wants to merge 1 commit into
devfrom
ci/build-tests-test-path
Draft

openvoiceos-bot wants to merge 1 commit into
devfrom
ci/build-tests-test-path

Conversation

@openvoiceos-bot

Copy link
Copy Markdown
Contributor

The defect

The Build Tests job here ran no test and reported success.

build-tests.yml gates its Run Tests step on inputs.test_path != '',
and its result step only reports tests_failed when the same input is
set. With no test_path the job builds the wheel, installs it, skips the
tests and is green. The only trace is the summary artifact, which reads
no pytest summary.

The change

      test_path: 'tests'

Controls

The edit was verified by parsing the workflow and reading test_path back
out of it, not by trusting the text edit.

Canary for this sweep: ovos-tts-plugin-SAM#38. The same one-line change
took that job from running no test to 23 passed, 52 subtests passed, on
all five interpreters, with test/end2end confirmed not collected.

What to expect

17 repositories call this workflow with no test_path. If tests fail
here, that is a real failure that was hidden all along, not a regression
from this change, and it gets filed rather than silenced.


Generated for T-5499.

🤖 Generated with Claude Code

@github-actions github-actions Bot added the fix label Sep 26, 2026
@coderabbitai

coderabbitai Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Checking in! Here's how the automated tests are looking. 🧐

I've aggregated the results of the automated checks for this PR below.

📋 Repo Health

Scanning for any signs of 'dependency' parasites. 🐛

✅ All required files present.

Latest Version: 2.2.2a1

✅ hivemind_audio_binary_protocol/version.py — Version file
✅ README.md — README
✅ LICENSE — License file
✅ pyproject.toml — pyproject.toml
⚠️ setup.py — setup.py
🗑️ requirements.txt — legacy: pyproject.toml is present; this file is no longer needed
✅ CHANGELOG.md — Changelog
✅ hivemind_audio_binary_protocol/version.py has valid version block markers

⚖️ License Check

Ensuring our EULA (if any) is still valid. 📑

✅ No license violations found.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🔒 Security (pip-audit)

Ensuring our project remains safe and secure. 🛡️

✅ No known vulnerabilities found (82 packages scanned).

📊 Coverage

Is the code wearing its test-suit? Let's see. 👔

⚠️ 73.8% total coverage

Per-file coverage (4 files)
File Coverage Missing lines
hivemind_audio_binary_protocol/version.py 0.0% 5
hivemind_audio_binary_protocol/protocol.py 73.8% 89
hivemind_audio_binary_protocol/transformers.py 88.0% 3
hivemind_audio_binary_protocol/__init__.py 100.0% 0

Full report: download the coverage-report artifact.

🔍 Lint

Everything looks good so far! ✅

❌ ruff: issues found in 12 file(s) — see job log
✅ actionlint: 11 workflow file(s), no finding

🔌 Plugin Detection

Ensuring the plugin remains easy to discover and install. 🔌

ℹ️ Not an OVOS plugin — OPM check skipped.

🏷️ Release Preview

Ensuring the 'Dependency Updates' are documented. 📦

Current: 2.2.2a1 → Next: 2.2.3a1

Signal Value
Label fix
PR title fix(ci): set test_path so the build test actually runs the tests
Bump build

⚠️ No conventional commit prefix — alpha-only bump.
Suggested: fix: update the thing or feat: update the thing


🚀 Release Channel Compatibility

Predicted next version: 2.2.3a1

Channel Status Note Current Constraint
Stable ⚪ Not in channel -
Testing ✅ Compatible hivemind-audio-binary-protocol>=2.1.3,<3.0.0
Alpha ✅ Compatible hivemind-audio-binary-protocol>=2.2.2a1

🔨 Build Tests

From source to binary, let's see how it holds up. 🧱

✅ All versions pass

Python Build Install Tests pytest
3.10 ✅ ✅ ✅ 25 passed, 50 warnings in 15.33s
3.11 ✅ ✅ ✅ 25 passed, 50 warnings in 14.36s
3.12 ✅ ✅ ✅ 25 passed, 50 warnings in 10.39s
3.13 ✅ ✅ ✅ 25 passed, 50 warnings in 16.07s

Keeping things running like clockwork 🕰️

…lly run

The Build Tests job passed no test_path. The reusable workflow gates its Run
Tests step on `inputs.test_path != ''`, and its result step only reports
tests_failed when the same input is set, so this job built the wheel, installed
it, ran no test at all and reported success.

Setting test_path alone then failed collection with
`ModuleNotFoundError: No module named 'hivemind_core'`, because the caller also passed
no install_extras, so the `test` extra that carries hivescope was never
installed. That is the same defect as the missing test_path: a caller that does
not pass what the workflow needs. hivemind-mic-satellite already passes
`install_extras: 'e2e'` and its e2e suite runs, which is the control that this
is a caller gap and not a broken suite.

Both inputs are now set. Verified by reading them back out of the parsed
workflow.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@JarbasAl
JarbasAl force-pushed the ci/build-tests-test-path branch from 664023f to 72988ff Compare September 26, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants