Repository navigation
fix(ci): set test_path so the build test actually runs the tests - #69
openvoiceos-bot wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Checking in! Here's how the automated tests are looking. 🧐I've aggregated the results of the automated checks for this PR below. 📋 Repo HealthScanning for any signs of 'dependency' parasites. 🐛 ✅ All required files present. Latest Version: ✅ ⚖️ License CheckEnsuring our EULA (if any) is still valid. 📑 ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 🔒 Security (pip-audit)Ensuring our project remains safe and secure. 🛡️ ✅ No known vulnerabilities found (82 packages scanned). 📊 CoverageIs the code wearing its test-suit? Let's see. 👔 Per-file coverage (4 files)
Full report: download the 🔍 LintEverything looks good so far! ✅ ❌ ruff: issues found in 12 file(s) — see job log 🔌 Plugin DetectionEnsuring the plugin remains easy to discover and install. 🔌 ℹ️ Not an OVOS plugin — OPM check skipped. 🏷️ Release PreviewEnsuring the 'Dependency Updates' are documented. 📦 Current:
🚀 Release Channel Compatibility Predicted next version:
🔨 Build TestsFrom source to binary, let's see how it holds up. 🧱 ✅ All versions pass
Keeping things running like clockwork 🕰️ |
…lly run The Build Tests job passed no test_path. The reusable workflow gates its Run Tests step on `inputs.test_path != ''`, and its result step only reports tests_failed when the same input is set, so this job built the wheel, installed it, ran no test at all and reported success. Setting test_path alone then failed collection with `ModuleNotFoundError: No module named 'hivemind_core'`, because the caller also passed no install_extras, so the `test` extra that carries hivescope was never installed. That is the same defect as the missing test_path: a caller that does not pass what the workflow needs. hivemind-mic-satellite already passes `install_extras: 'e2e'` and its e2e suite runs, which is the control that this is a caller gap and not a broken suite. Both inputs are now set. Verified by reading them back out of the parsed workflow. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
664023f to
72988ff
Compare
The defect
The Build Tests job here ran no test and reported success.
build-tests.ymlgates its Run Tests step oninputs.test_path != '',and its result step only reports
tests_failedwhen the same input isset. With no
test_paththe job builds the wheel, installs it, skips thetests and is green. The only trace is the summary artifact, which reads
no pytest summary.The change
Controls
The edit was verified by parsing the workflow and reading
test_pathbackout of it, not by trusting the text edit.
Canary for this sweep: ovos-tts-plugin-SAM#38. The same one-line change
took that job from running no test to
23 passed, 52 subtests passed, onall five interpreters, with
test/end2endconfirmed not collected.What to expect
17 repositories call this workflow with no
test_path. If tests failhere, that is a real failure that was hidden all along, not a regression
from this change, and it gets filed rather than silenced.
Generated for T-5499.
🤖 Generated with Claude Code