Repository navigation
Conversation
xs1997zju
added this pull request to stack #2112
October 8, 2026 13:11
xs1997zju
marked this pull request as ready for review
October 8, 2026 13:13
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬
Stack #2112 (bottom to top):
Base:
feat/glm53flash-f7-logits-parity(#2139). Review this layer against its base.The existing HF↔XTuner real-checkpoint accuracy test now runs its four original text cases plus one single-image and one two-image case through the same forward/loss/logits comparison loop. Only
tests/model/test_glm53_text_moe.pychanges; no separate replay entry point or dataset pipeline is added.Use the full compose model and the existing repository cat image. The image cases share processor outputs between HF and XTuner, mask image placeholders from labels, and compare full-vocabulary logits at the final eight supervised next-token positions. Text and image loss checks are evaluated separately with the existing thresholds; per-sample logits thresholds remain relative L2 <5% and cosine >0.998.
XT vision uses FlashAttention; native HF uses eager because the installed Transformers vision implementation does not support FlashAttention 2. This does not claim identical attention kernels.
Validation:
Only eval/no-grad forward was tested. No backward, optimizer updates, packing, MTP, video, or SP2 validation is claimed for this layer.